1344845 - --disable-sandbox broken: fatal error: sandboxPermissions.h: No such file or directory

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

I believe https://bugzilla.mozilla.org/show_bug.cgi?id=1284897 broke --disable-sandbox:

> firefox/dom/ipc/ContentChild.cpp:63:0:
> dist/include/mozilla/plugins/PluginModuleParent.h:27:32: fatal error: sandboxPermissions.h: No such file or directory
> compilation terminated.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1344845 Fix --disable-sandbox by ifdef-ing an include

Review commit: https://reviewboard.mozilla.org/r/117660/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117660/

Comment 2

[David Parks [:handyman]]

Comment on attachment 8844120 [details]
Bug 1344845 Fix --disable-sandbox by ifdef-ing an include

https://reviewboard.mozilla.org/r/117660/#review119350

Good catch, thanks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9399e0ccde82
Fix --disable-sandbox by ifdef-ing an include. r=handyman

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9399e0ccde82

Comment 5

[Julien Cristau [:jcristau]]

Bug 1284897 is in 54, do we want to uplift this to beta as well?

Comment 6

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

(In reply to Julien Cristau [:jcristau] from comment #5)
> Bug 1284897 is in 54, do we want to uplift this to beta as well?

I don't need it uplifted, as Tor will not build 54. If you or someone else want it uplifted for completeness reasons, then sure.