1344974 - Eliminate virtual calls in xpc::AccessCheck methods

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement)

Description

[(no longer active)]

Follow-up from bug 1340710.  Bobby, is this what you meant in bug 1340710 comment 77?

Comment 1

[(no longer active)]

Also, I'd like to try to inline some code here as well.  What do you think about that?  I'm asking because sometimes I get push back due to adding code in headers and #include dependencies and whatnot.

Comment 2

[Bobby Holley (:bholley)]

I was specifically talking about the nsIPrincipal methods called in xpc::WrapperFactory::Rewrap [1], which end up in AccessCheck via things like [2].

All those can be replaced with BasePrincipal::Cast(prin)->Fast{Equals,Subsumes}{,ConsideringDomain}.

I am fine with inlining code here, and indeed would be interested to see that. I don't care about includes as long as it's not a crazy number of them.

[1] http://searchfox.org/mozilla-central/rev/1bc7720a434af3c13b68b8d69f92078cae8890c4/js/xpconnect/wrappers/WrapperFactory.cpp#466
[2] http://searchfox.org/mozilla-central/rev/1bc7720a434af3c13b68b8d69f92078cae8890c4/js/xpconnect/wrappers/AccessCheck.cpp#66

Comment 3

[(no longer active)]

Attachment: Part 1: Factor out more non-virtual helpers for principal equality/subsumption checks

Comment 4

[(no longer active)]

Attachment: Part 2: Make the non-virtual helpers for principal equality/subsumption checks inline

Comment 5

[(no longer active)]

Attachment: Part 3: Speed up principal access checks in WrapperFactory::Rewrap() by eliminating virtual dispatch and inling

Comment 6

[Bobby Holley (:bholley)]

Comment on attachment 8844315 [details] [diff] [review]
Part 1: Factor out more non-virtual helpers for principal equality/subsumption checks

Review of attachment 8844315 [details] [diff] [review]:
-----------------------------------------------------------------

::: caps/BasePrincipal.h
@@ +290,3 @@
>    // Call this instead of Subsumes to avoid the const of virtual dispatch.
>    bool FastSubsumes(nsIPrincipal* aOther);
> +  // Call this instead of SubsumesConsideringDomain to avoid the const of virtual dispatch.

Nit: "cost" rather than "const", here and below. But please just have one comment saying "Call these" and group them together.

Comment 7

[Bobby Holley (:bholley)]

Comment on attachment 8844316 [details] [diff] [review]
Part 2: Make the non-virtual helpers for principal equality/subsumption checks inline

Review of attachment 8844316 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming this is just moving code around (I didn't review in much detail).

Comment 8

[Bobby Holley (:bholley)]

Comment on attachment 8844317 [details] [diff] [review]
Part 3: Speed up principal access checks in WrapperFactory::Rewrap() by eliminating virtual dispatch and inling

Review of attachment 8844317 [details] [diff] [review]:
-----------------------------------------------------------------

Could be worth inlining these too at some point.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c8caf7ff9f2
Part 1: Factor out more non-virtual helpers for principal equality/subsumption checks; r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/a84b225957b4
Part 2: Make the non-virtual helpers for principal equality/subsumption checks inline; r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9c886b3517f
Part 3: Speed up principal access checks in WrapperFactory::Rewrap() by eliminating virtual dispatch and inling; r=bholley

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2c8caf7ff9f2
https://hg.mozilla.org/mozilla-central/rev/a84b225957b4
https://hg.mozilla.org/mozilla-central/rev/a9c886b3517f