1345079 - Allowing screensharing with no screen selected will temporarily block the camera

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Johann Hofmann [:johannh]]

STR:

- Go to https://people-mozilla.org/~fqueze2/webrtc/
- Click on "Screen"
- Click "Allow" without selecting a screen to share
- Notice that the camera is temporarily blocked

This is because this line http://searchfox.org/mozilla-central/source/browser/modules/webrtcUI.jsm#752 assumes we always share the camera and doesn't account for sharingScreen.

It should probably simply return; when sharingScreen is true since that means the user has not selected a screen. I don't think it's fair to temp block the website here as the user could have made that choice accidentally.

Comment 1

[Florian Quèze [:florian]]

[Tracking Requested - why for this release]: regression from bug 1206232 which landed for 53.

Comment 2

[Johann Hofmann [:johannh]]

Nihanth, would you like to take this bug?

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1345079 - Allowing screensharing with no screen selected should not block the camera.

Review commit: https://reviewboard.mozilla.org/r/119786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119786/

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8846782 [details]
Bug 1345079 - Allowing screensharing with no screen selected should not block the camera.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/119786/diff/1-2/

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 8846782 [details]
Bug 1345079 - Allowing screensharing with no screen selected should not block the camera.

https://reviewboard.mozilla.org/r/119786/#review121668

Looks great, thanks for spotting the redundant else branch there.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Please land and request uplift to 54 and 53.  Thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45028a73f2c9
Allowing screensharing with no screen selected should not block the camera. r=johannh

Comment 8

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8846782 [details]
Bug 1345079 - Allowing screensharing with no screen selected should not block the camera.

Approval Request Comment
[Feature/Bug causing the regression]: Regression from bug 1206232
[User impact if declined]: Confusing behavior, see bug title.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no, but STR are in comment 0.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: It removes a block of code that sets "block" permission within the callback for the "Allow" button. That code shouldn't be there, and removing it can't cause any harm.
[String changes made/needed]: none

Comment 9

[Gerry Chang [:gchang]]

Track 53+ as regression.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/45028a73f2c9

Comment 11

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 55.0a1 (2017-03-07) (64-bit) on Windows 7 , 64 Bit!

This bug's fix is verified with latest Nightly!

Build ID   : 20170317030204
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170315]

Comment 12

[Hani Yacoub, Desktop QA]

Build ID: 20170317030204
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

Verified as fixed on Firefox Nightly 55.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

Comment 13

[Gerry Chang [:gchang]]

Comment on attachment 8846782 [details]
Bug 1345079 - Allowing screensharing with no screen selected should not block the camera.

Fix a regression issue related to permission and was verified. Aurora54+ & Beta53+.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/660fe0a12cf6

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/347d062eb8e9

Comment 16

[Hani Yacoub, Desktop QA]

Build ID: 20170321004003
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0

Verified as fixed on Firefox Aurora 54.0a2 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

Comment 17

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Beta 53.0b5 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.