Closed Bug 1345095 Opened 7 years ago Closed 7 years ago

Intermittent dom/media/tests/mochitest/test_peerConnection_capturedVideo.html | Test attempted to use a flaky timeout value 180000

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jwwang)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Comment on attachment 8844764 [details]
Bug 1345095 - ensure SimpleTest.js is loaded before all other scripts.

https://reviewboard.mozilla.org/r/118084/#review120106

r=me minus noisy log statements.

::: dom/media/tests/mochitest/pc.js:1896
(Diff revision 1)
> +    dump(`loading script: ${script}\n`);
> -  el.src = script;
> +    el.src = script;
> -  document.head.appendChild(el);
> +    document.head.appendChild(el);
> -  return new Promise(r => { el.onload = r; el.onerror = r; });
> +    return new Promise(r => {
> +      var f = () => {
> +        dump(`script loaded: ${script}\n`);

Did you mean to leave these `dump` statements in here?
Attachment #8844764 - Flags: review?(jib) → review+
Assignee: nobody → jwwang
Thanks! I will remove the dump() calls.
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c44ae7588ae4
ensure SimpleTest.js is loaded before all other scripts. r=jib
https://hg.mozilla.org/mozilla-central/rev/c44ae7588ae4
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: