Open
Bug 1345209
Opened 7 years ago
Updated 2 years ago
Refactor JS_STANDALONE related configs out of root 'moz.build' for use in js/src/make-source-package.sh
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(Not tracked)
NEW
People
(Reporter: ahal, Unassigned)
References
Details
It looks like the sm-pkg task copies a bunch of random files from around the tree into a package, runs the root moz.build file, and expects everything to work. This caused a bunch of pain trying to work around in bug 1345109. It also results in a whole lot of: if not CONFIG['JS_STANDALONE'] conditions scattered in moz.builds all around the tree. We will need to add way more of these conditions if we stop conditionally including DIRS (which I think is a good thing to work towards). I don't really know the best way to solve this, but instead of copying the root moz.build, maybe the sm-pkg task could redefine its own "root" moz.build? If it's really important to share changes between the two, maybe we could refactor the root moz.build into two root moz.build's: one that contains JS_STANDALONE stuff, and one that doesn't (which also includes the former).
Updated•6 years ago
|
Product: Core → Firefox Build System
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•