Closed Bug 1345338 Opened 7 years ago Closed 7 years ago

[SEO] Update titles and metadata in top search impression pages under mozilla.org/firefox/*

Categories

(www.mozilla.org :: Pages & Content, defect)

Production
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: erenaud, Unassigned)

References

Details

Justin - please add your recommendations here
Flags: needinfo?(hoosteeno)
This spreadsheet contains the URLs, new titles, and new meta descriptions. The list of URLs is slightly different than comment 0.

https://docs.google.com/spreadsheets/d/1kFpqkkssd-keOyVS13azQS_iJ8ESNtvqjZ5TLy5hBq0/edit#gid=0

Let me know if you have any questions!
Flags: needinfo?(hoosteeno)
Craig, can you assess the level of effort required for this?
Flags: needinfo?(craigcook.bugz)
Minimal effort. The new strings will need to be behind an l10n tag.
Flags: needinfo?(craigcook.bugz)
Eric, can you and David sync up to see where this prioritizes? (Minimal effort - High potential impact)
Flags: needinfo?(erenaud)
:craigcook, can you clarify comment 4? Since this is low effort, high-impact work, I'd like to go ahead and PR it. Does "behind an l10n tag" mean "inside an en-US conditional", as exemplified by code in the recent footer work[0]? If so, we can follow that pattern in our PR.

[0] https://github.com/mozilla/bedrock/commit/c65772b51cecf16961f1c70678467abb2c866958#diff-363e202ec11e7316223054c95bac9284R138
Flags: needinfo?(craigcook.bugz)
(In reply to Justin Crawford [:hoosteeno] [:jcrawford] from comment #6)
> :craigcook, can you clarify comment 4? Since this is low effort, high-impact
> work, I'd like to go ahead and PR it. Does "behind an l10n tag" mean "inside
> an en-US conditional", as exemplified by code in the recent footer work[0]?
> If so, we can follow that pattern in our PR.

Yes, it could be either an en- conditional or a named l10n tag like this: https://github.com/mozilla/bedrock/blob/master/bedrock/mozorg/templates/mozorg/home/home.html#L83

Both methods let us avoid showing English text on an otherwise translated page, but there's some difference in how they're treated by l10n and where/when we use which method.

For strings that are in a page's own lang file, an l10n tag lets each locale indicate when the string has been localized, and the template conditional says "if the lang file has this tag, show the new translated string, else show the old translated string (or nothing)." That's preferable in most cases.

The footer strings are global, shared across all pages and contained in a global lang file, so we can't use a regular l10n tag. To avoid mixed languages, the en- conditional has to remain in place until *all* locales (or at least almost all) can get that string translated. An l10n tag lets locales get the new strings sooner, rather than wait for all locales.

I think for this metadata, which appears on individual pages and not globally, we should use an l10n tag. I'm not sure if all pages touched in this update should share the same tag name or if we should make it a different tag per page. CCing Peiying for guidance and general in-looping.

Also, do you plan to tweak titles/descriptions repeatedly to test different versions, or do you expect them to remain pretty permanent? We shouldn't begin l10n until strings are stable.
Flags: needinfo?(craigcook.bugz)
> I think for this metadata, which appears on individual pages and not
> globally, we should use an l10n tag.

Thank you.

> Also, do you plan to tweak titles/descriptions repeatedly to test different
> versions, or do you expect them to remain pretty permanent? We shouldn't
> begin l10n until strings are stable.

I don't think we should count on anything in our Firefox product marketing pages to remain pretty permanent. We're talking about a complete subsite overhaul, which means everything we do now is temporary. And I hope one outcome of the overhaul is a site that we can experiment with, which means everything we do later is temporary.

These strings are probably as stable as the pages they land on.

:fpolizzi, do you have bandwidth to take this on?
Flags: needinfo?(francescosapolizzi)
Peiying - can you please review the proposal here and Craig's questions about impact to l10n in comment 7?
Flags: needinfo?(erenaud) → needinfo?(pmo)
> 
> The footer strings are global, shared across all pages and contained in a
> global lang file, so we can't use a regular l10n tag. To avoid mixed
> languages, the en- conditional has to remain in place until *all* locales
> (or at least almost all) can get that string translated. An l10n tag lets
> locales get the new strings sooner, rather than wait for all locales.
> 
> I think for this metadata, which appears on individual pages and not
> globally, we should use an l10n tag. I'm not sure if all pages touched in
> this update should share the same tag name or if we should make it a
> different tag per page. CCing Peiying for guidance and general in-looping.

The suggested solution is good from l10n perspective.
> 
> Also, do you plan to tweak titles/descriptions repeatedly to test different
> versions, or do you expect them to remain pretty permanent? We shouldn't
> begin l10n until strings are stable.

The constant change (or not having a more stable one) will cause problems for l10n.  As soon as one is done, the new one is to replace it. Some locales may have not finished footer A when footer B appears.  How many do we have in mind with this experiment?
Flags: needinfo?(pmo)
> 
> The constant change (or not having a more stable one) will cause problems
> for l10n.  As soon as one is done, the new one is to replace it. Some
> locales may have not finished footer A when footer B appears.  How many do
> we have in mind with this experiment?

This change will remain in place until the pages themselves are redesigned and rewritten. That may be in Q2.
Since we agree a named tag is the right approach, we need to decide on the tag. Bedrock docs[0] suggest coordinating with l10n team on this.

I suggest we call this tag, "firefox_title_meta_2017q1". Peiying, does that seem like a good tag?

[0] http://bedrock.readthedocs.io/en/latest/l10n.html#staging-copy-changes
Flags: needinfo?(pmo)
(In reply to Justin Crawford [:hoosteeno] [:jcrawford] from comment #12)
> Since we agree a named tag is the right approach, we need to decide on the
> tag. Bedrock docs[0] suggest coordinating with l10n team on this.
> 
> I suggest we call this tag, "firefox_title_meta_2017q1". Peiying, does that
> seem like a good tag?
> 
> [0] http://bedrock.readthedocs.io/en/latest/l10n.html#staging-copy-changes

Looks good as long as we have no more than one tag per quarter and we stay with the same naming convention.
Flags: needinfo?(pmo)
Good point about "one per quarter". I think we would get more value out of adding a bug number to the string; the date information is in the bug along with lots of other helpful info. So I suggest...

firefox_title_meta_bug1345338
PR is ready for review: https://github.com/mozilla/bedrock/pull/4736
Flags: needinfo?(francescosapolizzi)
Jon - could you please pick up this review as a priority (over the firefox/desktop page, which has some design elements in need of address before coding)
Flags: needinfo?(jon)
PR has been reviewed with a few changes requested.
Flags: needinfo?(jon)
PR updated. :jpetto, r?

Peiying, any chance we still need the Firefox Hello l10n stuff outlined here?: https://github.com/mozilla/bedrock/pull/4736#discussion-diff-108439677L9
Flags: needinfo?(pmo)
Flags: needinfo?(jon)
Covering for Peiying in-between flights: we have 72 locales done for "Firefox – Desktop browser, Android, iOS, Sync, Private Browsing", it's safe to use that as fallback and drop the two strings using Hello, and the tag "fx49_remove_hello".
Flags: needinfo?(pmo)
(In reply to Francesco Lodolo [:flod] from comment #19)
> Covering for Peiying in-between flights: we have 72 locales done for
> "Firefox – Desktop browser, Android, iOS, Sync, Private Browsing", it's safe
> to use that as fallback and drop the two strings using Hello, and the tag
> "fx49_remove_hello".

Does this include replacing the "tracking_protection" tagged content in favor of "Firefox – Desktop browser, Android, iOS, Sync, Private Browsing"?
Flags: needinfo?(francesco.lodolo)
:fpolizzi - Covering for :flod now. ;) I believe the logic on /firefox/family/index.html should be:

{% if l10n_has_tag('firefox_title_meta_bug1345338') %}
  {{ _('Free Web Browser for Android, iOS, Desktop | Firefox') }}
{% else %}
  {{ _('Firefox – Desktop browser, Android, iOS, Sync, Private Browsing') }}
{% endif %}

Can you make this update in the PR? Thanks!
Flags: needinfo?(jon)
Flags: needinfo?(francescosapolizzi)
Flags: needinfo?(francesco.lodolo)
Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/371cee6ce01e50386dfb222f937f20f688a7b519
fix bug 1345338 Update titles+metadata on mozilla.org/firefox/* (#4736)

[fix bug 1345338] Update titles + metadata on mozilla.org/firefox/*

* fix bug 1345338 Update titles+metadata on mozilla.org/firefox/*

* fix bug 1345338 Update titles+metadata on mozilla.org/firefox/*
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
These changes have been picked up by search engines, and I can see the source isn't showing up as expected. Here's the iOS page:

https://www.mozilla.org/en-US/firefox/ios/

It's title is here:

    <title>Firefox for iOS — 

  Free Mobile Browser App for iPhone, iPad, iOS | Firefox

 — Mozilla</title>

Titles are picking up a prefix and suffix, which you see on the top and bottom lines of the source above. We need to prevent that.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
:hoosteeno would you mind opening a new bug for this? This one is already a bit long and it'd be nice to start fresh on this issue.
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/636174aade43f0974fa4e8e43a903b80696ce9cd
Bug 1345338 follow-up: update fallback title in firefox/channel iOS page

https://github.com/mozilla/bedrock/commit/34a872da6378b6a77d7a4b6bfe38d2e2924c8b70
Merge pull request #4751 from flodolo/bug1345338

Bug 1345338 follow-up: update fallback title in firefox/channel iOS page
You need to log in before you can comment on or make changes to this bug.