Closed Bug 1345363 Opened 7 years ago Closed 7 years ago

Debugging information output when a test is timing out is truncated

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jya, Unassigned)

Details

Attachments

(1 file)

When a test time out, debugging information is output on the console.

However, the text is truncated which makes it difficult to guess what has happened some times.

Example:
14:35:52     INFO - [1741] WARNING: Decoder=11f837400 channels=2 rate=22050 hasAudio=1 hasVideo=1 mPlayState=LOADING mdsm=11f815000
14:35:52     INFO - reader data:
14:35:52     INFO - audio decoder: apple CoreMedia decoder
14:35:52     INFO - audio frames decoded: 0
14:35:52     INFO - audio state: ni=0 no=0 wp:1 demuxr:0 demuxq:0 decoder:0 tt:-1.0 tths:-1 in:1 out:0 qs=1 pending:0 wfd:1 wfk:0 sid:6
14:35:52     INFO - video decoder: apple hardware VT decoder
14:35:52     INFO - hardware video decoding: enabled
14:35:52     INFO - video frames decoded: 22 (skipped:0)
14:35:52     INFO - video state: ni=0 no=0 wp:0 demuxr:0 demuxq:0 decoder:0 tt:-1.0 tths:-1 in:24 out:24

Here it's missing about 1/3rd of the full content.

My guess is that as it's output using NS_WARNING, the length allowed is actually limited and the content is truncated.
http://searchfox.org/mozilla-central/rev/d4adaabd6d2f88be0d0b151e022c06f6554909da/xpcom/base/nsDebugImpl.cpp#275
We should increase the buffer size to 1k or more.
Component: Audio/Video: Playback → XPCOM
Comment on attachment 8845846 [details]
Bug 1345363: Don't truncate debugging information.

https://reviewboard.mozilla.org/r/118988/#review121028
Attachment #8845846 - Flags: review?(jwwang) → review+
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/80943e8c132b
Don't truncate debugging information. r=jwwang
https://hg.mozilla.org/mozilla-central/rev/80943e8c132b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: