1345474 - Support incognito permission "not_allowed"

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Erik Vold]

So far it appears that the only mode supported is "spanning" as described here: https://developer.chrome.com/extensions/manifest/incognito#spanning

"not_allowed" is not supported..

Comment 1

[John Gruen [:jgruen]]

Andym, Screenshots would like to be able to use 'spanning eventually. Should i file a separate bug or simply update the title here?

Comment 2

[Andy McKay]

I don't think we have a bigger private browsing bug yet. I would file another bug make it a tracker and block this particular part of the API on that bug... and then file a request for spanning as well :)

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1345474 - Add policy flags to support incognito settings

Bug 1345474 - Check incognito access for content scripts

Bug 1345474 - protect access to base window and tab classes

Bug 1345474 - Check incognito access for tabs api

Bug 1345474 - Check incognito access for windows api

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1345474 - Add not_supported to schema for incognito

Depends on D3702

Comment 5

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1345474 - Add policy flags to support incognito settings

Depends on D4096

Comment 6

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1345474 - Check incognito access for content scripts

Depends on D4100

Comment 7

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1345474 - protect access to base window and tab classes

Depends on D4109

Comment 8

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1345474 - Check incognito access for tabs api

Depends on D4110

Comment 9

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1345474 - Check incognito access for windows api

Depends on D4111

Comment 10

[Shane Caraveo (:mixedpuppy)]

Looking for feedback on direction before proceeding further, not looking for code review.

Patches add:

- not_allowed
- ability to run tests in in one mode (PB or not) 
  - currently background script runs as in spanning mode
- policy checking for
  - content scripts
  - tabs api
  - windows api

Notes:

"incognitoMode" in the first patch may be removed later in favor of policy-only values.
event handling is potentially onerous, may look at moving to eventmanager
APIs need to be individually checked
Each API needs review and updated with access checks
May add pref-off and land interim work so others can help 

Would like to know:

Anyone see a better way to implement the access checks in the apis/events?
Kris, how does the policy changes look to you?

Comment 11

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1345474 - Check incognito access for webRequest api

Depends on D4112

Comment 12

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce48ee59cf3c84c1aba3b60ae554f391e96a0d7a

Comment 13

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f711321563cf85869e927e0dc50461889ec256b

Comment 14

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d280acd3849f3f86393855692511a8b5a1e9074

Comment 15

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4030040515451377b237faae1c79475f29fc812d

Comment 16

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=76cd4d218fe58fe3b68bbef9f825bbb8cd1c26ee

Comment 17

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=66ac668740770bbd8cc96c3c75c2531f6a7dcce2

Comment 18

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1345474 - support showInPrivateBrowsing in browserAction, r?rpl

Depends on D5571

Comment 19

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1345474 - Check incognito access for cookies api, r?rpl

Depends on D11670

Comment 20

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1345474 - Check incognito access for theme api, r?rpl

Comment 21

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2781020c1c9622a3ec574c241786d248375cbe65

Comment 22

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1345474 - Check incognito access for webNavigation api, r?rpl

Comment 23

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b15cc778c2ca6601bd7e5326aac5ca68a87b525a

Comment 24

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d51035cdaf38fdf98707b725f6962ac253cd618b

Comment 25

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=36992aa269ed5ff79b055371f4325b2efd445433

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae6af51f926f
Add policy flags to support incognito settings r=rpl,kmag
https://hg.mozilla.org/integration/autoland/rev/4dd4dc96ab00
Check incognito access for content scripts r=rpl
https://hg.mozilla.org/integration/autoland/rev/692f949c68ee
protect access to base window and tab classes r=rpl
https://hg.mozilla.org/integration/autoland/rev/192488fbd1a8
Check incognito access for tabs api r=rpl
https://hg.mozilla.org/integration/autoland/rev/971e9c783d75
Check incognito access for windows api r=rpl
https://hg.mozilla.org/integration/autoland/rev/2dec84de93b8
Check incognito access for webRequest api r=kmag
https://hg.mozilla.org/integration/autoland/rev/43b66faad595
support showInPrivateBrowsing in browserAction, r=rpl
https://hg.mozilla.org/integration/autoland/rev/4d887e5467d0
Check incognito access for cookies api, r=rpl
https://hg.mozilla.org/integration/autoland/rev/acbcbc1e09ad
Check incognito access for theme api, r=rpl
https://hg.mozilla.org/integration/autoland/rev/1f6a5ab63089
Check incognito access for webNavigation api, r=rpl

Comment 27

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ae6af51f926f
https://hg.mozilla.org/mozilla-central/rev/4dd4dc96ab00
https://hg.mozilla.org/mozilla-central/rev/692f949c68ee
https://hg.mozilla.org/mozilla-central/rev/192488fbd1a8
https://hg.mozilla.org/mozilla-central/rev/971e9c783d75
https://hg.mozilla.org/mozilla-central/rev/2dec84de93b8
https://hg.mozilla.org/mozilla-central/rev/43b66faad595
https://hg.mozilla.org/mozilla-central/rev/4d887e5467d0
https://hg.mozilla.org/mozilla-central/rev/acbcbc1e09ad
https://hg.mozilla.org/mozilla-central/rev/1f6a5ab63089

Comment 28

[quasicomputational]

Is this hidden behind a pref? If I try to load an extension with "incognito": "not_allowed" on Nightly, it tells me that it's invalid.

Comment 29

[Shane Caraveo (:mixedpuppy)]

(In reply to quasicomputational from comment #28)

Is this hidden behind a pref? If I try to load an extension with "incognito": "not_allowed" on Nightly, it tells me that it's invalid.

You cannot use it yet, not until bug 1511636 lands. Then there is a pref to flip to enable it.

Comment 30

[Irene Smith]

The manifest key is already documented and I added a note that the default behavior is to not allow an extension to work in a private window or tab. I described the changes in more detail in bug 1511636

Comment 31

[Shane Caraveo (:mixedpuppy)]

(In reply to Irene Smith from comment #30)

The manifest key is already documented and I added a note that the default behavior is to not allow an extension to work in a private window or tab. I described the changes in more detail in bug 1511636

The pref should not be documented (and is documented incorrectly). Also, "split" is not supported and that should be highlighted on the page.

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/incognito

Comment 32

[Irene Smith]

I removed the note about the preference. The BCD at the bottom of the page says that split is not supported but I also added a comment at the end of the description of split that says it is not supported in Firefox.