1345719 - ActorsParent.cpp:8632:5: warning: 'removed' may be used uninitialized in this function [-Wmaybe-uninitialized]

Status: RESOLVED INVALID

(Core :: Storage: Quota Manager, defect, P3)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

mozilla-inbound/dom/quota/ActorsParent.cpp: In function 'nsresult mozilla::dom::quota::{anonymous}::UpgradeStorageFrom1_0To2_0Helper::DoUpgrade()':
mozilla-inbound/dom/quota/ActorsParent.cpp:8632:5: warning: 'removed' may be used uninitialized in this function [-Wmaybe-uninitialized]
mozilla-inbound/dom/quota/ActorsParent.cpp:8627:10: note: 'removed' was declared here

Comment 1

[Jan Varga [:janv]]

What compiler and what OS ?

I don't see any warnings on mac with clang. Treeherder is also happy and it uses --enable-warnings-as-errors as far as I know.

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Jan Varga [:janv] from comment #1)
> What compiler and what OS ?
> 
> I don't see any warnings on mac with clang. Treeherder is also happy and it
> uses --enable-warnings-as-errors as far as I know.
gcc 5.4, on Linux X86 64bit (Ubuntu 16.04). It's just the "-Wmaybe-uninitialized" option, and it won't stop the building process.

Comment 3

[jbonnafo]

Hello,
the |removed| boolean is declared but not initialized.
Its value is supposed to be set by a call to MaybeRemoveAppsData
But some paths in MaybeRemoveAppsData do not set the boolean to a value.
However, when MaybeRemoveAppsData does not set the boolean, the return value of the function seems to prevent reading the the uninitialized boolean.
So i din't think there is a bug here, what do you think?
Thanks,

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Close this bug.