1345773 - Don't call ctrlTab.updatePreview for TabAttrModified events for the "select" attribute

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[Dão Gottwald [:dao]]

We currently call updatePreview when any of these tab attributes change: label, busy, image, selected

However, a "select" attribute change doesn't really affect previews, so we should remove this from the list.

The code is here: https://hg.mozilla.org/mozilla-central/annotate/58753259bfeb3b818eac7870871b0aae1f8de64a/browser/base/content/browser-ctrlTab.js#l476

Comment 1

[Subhdeep Saha]

Attachment: Bug 1345773 - Don't call updatePreview for TabAttrModified events for the "select" attribute,

Review commit: https://reviewboard.mozilla.org/r/118646/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118646/

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8845496 [details]
Bug 1345773 - Don't call updatePreview for TabAttrModified events for the "select" attribute,

https://reviewboard.mozilla.org/r/118646/#review120558

::: commit-message-8fca4:1
(Diff revision 1)
> +Bug:1345773 Removed the 'selected' attribute from list r=dao

Please use this format:

Bug 1345773 - Don't call updatePreview for TabAttrModified events for the "select" attribute, r=dao

::: browser/base/content/browser-ctrlTab.js:477
(Diff revision 1)
>      switch (event.type) {
>        case "SSWindowRestored":
>          this._initRecentlyUsedTabs();
>          break;
>        case "TabAttrModified":
>          // tab attribute modified (i.e. label, busy, image, selected)

Could you please update this comment too?

Looks good otherwise. Thanks!

Comment 3

[Subhdeep Saha]

Comment on attachment 8845496 [details]
Bug 1345773 - Don't call updatePreview for TabAttrModified events for the "select" attribute,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/118646/diff/1-2/

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8845496 [details]
Bug 1345773 - Don't call updatePreview for TabAttrModified events for the "select" attribute,

https://reviewboard.mozilla.org/r/118646/#review120566

Perfect, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6bc677cfa1a
Don't call updatePreview for TabAttrModified events for the "select" attribute, r=dao

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c6bc677cfa1a