1345998 - Clean up some unused libs and delayloads in xul.dll.

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[(Away)]

Attachment: delayload

1:51.63 LINK : warning LNK4199: /DELAYLOAD:dbghelp.dll ignored; no imports found from dbghelp.dll
1:51.63 LINK : warning LNK4199: /DELAYLOAD:PowrProf.dll ignored; no imports found from PowrProf.dll
1:51.63 LINK : warning LNK4199: /DELAYLOAD:rasapi32.dll ignored; no imports found from rasapi32.dll
1:51.63 LINK : warning LNK4199: /DELAYLOAD:rasdlg.dll ignored; no imports found from rasdlg.dll

Comment 1

[(Away)]

It looks like windowscodecs.lib can go as well.

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8845623 [details] [diff] [review]
delayload

Review of attachment 8845623 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/library/moz.build
@@ -23,5 @@
>          SHARED_LIBRARY_NAME = 'xul'
>  
>      DELAYLOAD_DLLS += [
>          'comdlg32.dll',
> -        'dbghelp.dll',

fun fact: the dbghelp dependency moved to mozglue.dll when stackwalk moved there 2 years ago... but it doesn't have a delayload there.

@@ -28,3 @@
>          'netapi32.dll',
> -        'PowrProf.dll',
> -        'rasapi32.dll',

rasapi and rasdlg are leftover from bug 1236969. You can also remove rasdlg.h, raserror.h and ras.h from config/system_headers, although, for some reason the latter is used in toolkit/system/windowsproxy/nsWindowsSystemProxySettings.cpp, but it doesn't look like it's used for anything that would require the header to be in config/system_headers (which is also why there's no dependency on the libs).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c26f90d92f42
Clean up some unused libs and delayloads in xul.dll. r=glandium

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c26f90d92f42