Closed Bug 1346049 Opened 7 years ago Closed 7 years ago

stylo: Enable reftestts for checking stacking context in layout/reftests/web-animations

Categories

(Core :: CSS Parsing and Computation, enhancement, P2)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: hiro, Assigned: boris)

References

Details

Attachments

(1 file)

Bug 1346049 - Enable reftests for checking stacking context.
59 bytes, text/x-review-board-request
hiro
: review+
Details 
I don't know the reason yet, but those tests fail intermittently, very high frequent. 
An interesting point is that we have similar tests (checking stacking context) for CSS animations, but they are not intermittent.
Boris, could you please check that these tests don't cause intermittent failures with your patch for bug 1334036?
Flags: needinfo?(boris.chiou)
Sure!
(In reply to Hiroyuki Ikezoe (:hiro) from comment #0)
> I don't know the reason yet, but those tests fail intermittently, very high
> frequent. 
> An interesting point is that we have similar tests (checking stacking
> context) for CSS animations, but they are not intermittent.

Hi Hiro, does the "very high frequent" happens on local build? Or only happens on try server? (In other words, can you easily reproduce these intermittents?)
Flags: needinfo?(boris.chiou)
(In reply to Boris Chiou [:boris] from comment #3)
> (In reply to Hiroyuki Ikezoe (:hiro) from comment #0)
> > I don't know the reason yet, but those tests fail intermittently, very high
> > frequent. 
> > An interesting point is that we have similar tests (checking stacking
> > context) for CSS animations, but they are not intermittent.
> 
> Hi Hiro, does the "very high frequent" happens on local build? Or only
> happens on try server? (In other words, can you easily reproduce these
> intermittents?)

any way, I will send to try to check this.
(In reply to Boris Chiou [:boris] from comment #3)
> (In reply to Hiroyuki Ikezoe (:hiro) from comment #0)
> > I don't know the reason yet, but those tests fail intermittently, very high
> > frequent. 
> > An interesting point is that we have similar tests (checking stacking
> > context) for CSS animations, but they are not intermittent.
> 
> Hi Hiro, does the "very high frequent" happens on local build? Or only
> happens on try server? (In other words, can you easily reproduce these
> intermittents?)

Locally.  Has this been solved?
(In reply to Hiroyuki Ikezoe (:hiro) from comment #5)
> (In reply to Boris Chiou [:boris] from comment #3)
> > (In reply to Hiroyuki Ikezoe (:hiro) from comment #0)
> > > I don't know the reason yet, but those tests fail intermittently, very high
> > > frequent. 
> > > An interesting point is that we have similar tests (checking stacking
> > > context) for CSS animations, but they are not intermittent.
> > 
> > Hi Hiro, does the "very high frequent" happens on local build? Or only
> > happens on try server? (In other words, can you easily reproduce these
> > intermittents?)
> 
> Locally.  Has this been solved?

I enable all the stacking-context-{*} reftests in layout/reftests/web-animations/reftest.list, and
run "./mach reftest --disable-e10s layout/reftests/web-animations/reftest.list".

tried 10 times: always get this result locally (mac os):

REFTEST INFO | Successful: 18 (18 pass, 0 load only)
REFTEST INFO | Unexpected: 0 (0 unexpected fail, 0 unexpected pass, 0 unexpected asserts, 0 failed load, 0 exception)
REFTEST INFO | Known problems: 2 (2 known fail, 0 known asserts, 0 random, 0 skipped, 0 slow)

The 2 known problems are style-updates-on-xxxx.
(In reply to Boris Chiou [:boris] from comment #6)
> I enable all the stacking-context-{*} reftests in
> layout/reftests/web-animations/reftest.list, and
> run "./mach reftest --disable-e10s
> layout/reftests/web-animations/reftest.list".
> 
> tried 10 times: always get this result locally (mac os):
> 
> REFTEST INFO | Successful: 18 (18 pass, 0 load only)
> REFTEST INFO | Unexpected: 0 (0 unexpected fail, 0 unexpected pass, 0
> unexpected asserts, 0 failed load, 0 exception)
> REFTEST INFO | Known problems: 2 (2 known fail, 0 known asserts, 0 random, 0
> skipped, 0 slow)
> 
> The 2 known problems are style-updates-on-xxxx.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0823142defdbd3d7f04f279a66d02c76cf3cfca

We can check Rs16 in the try. Only style-updates-on-{*}s are not passed.
Thanks for confirming!
Assignee: nobody → boris.chiou
Blocks: 1334036
Status: NEW → ASSIGNED
Oops, I did accidentally add bug 1334036 into blocks..  And I can't change it to dependency list because recursive dependencies?
No longer blocks: 1334036
See Also: → 1334036
No longer blocks: 1302945
Depends on: 1302945, 1334036
See Also: 1334036 → 
I tested 100 times locally with patches of bug 1334036 (on MacOS, --disable-e10s), but unfortunately, when I ran the reftest.list (in layout/reftests/web-animations) in the first trial, still have one intermittent: "stacking-context-transform-changing-display-property.html", and the rest 99 trials, all tests are passed. (probability: 1/100).

I start to believe maybe it's the problem of the environment of my laptop because I cannot test reftest with e10s (resolution is too low.) and this only happened in the first trial. (／‵Д′)／~ ╧╧
Comment on attachment 8867643 [details]
Bug 1346049 - Enable reftests for checking stacking context.

https://reviewboard.mozilla.org/r/139234/#review144446
Attachment #8867643 - Flags: review?(hikezoe) → review+
(In reply to Boris Chiou [:boris] from comment #11)
> I tested 100 times locally with patches of bug 1334036 (on MacOS,
> --disable-e10s), but unfortunately, when I ran the reftest.list (in
> layout/reftests/web-animations) in the first trial, still have one
> intermittent: "stacking-context-transform-changing-display-property.html",
> and the rest 99 trials, all tests are passed. (probability: 1/100).
> 
> I start to believe maybe it's the problem of the environment of my laptop
> because I cannot test reftest with e10s (resolution is too low.) and this
> only happened in the first trial. (／‵Д′)／~ ╧╧

Yeah, I couldn't run some reftest with e10s either. In Taipei Shing told me that there are some tests that are not able to run with e10s.

Anyway, let's see what happens on our automation servers.
Pushed by bchiou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f251b0f3faee
Enable reftests for checking stacking context. r=hiro
https://hg.mozilla.org/mozilla-central/rev/f251b0f3faee
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: