Closed
Bug 1346167
Opened 7 years ago
Closed 7 years ago
eslint-plugin-mozilla environments need to be more flexible if used outside mozilla-* repositories
Categories
(Developer Infrastructure :: Lint and Formatting, defect)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
I'm trying to get an up-to-date version of eslint-plugin-mozilla onto npm. Unfortunately the current version fails as there are issues in some of the environments - they require loading files which aren't in m-c repositories. To get around this, I think it is reasonably safe to skip adding variables to those environments if the files are missing. We should then be able to use some of the rules in other repositories. Ideally at some stage, I'd like to make a way where we could get these environments to work outside m-c, but for now, lets do this as a first step.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8845858 [details] Bug 1346167 - Make the eslint-plugin-mozilla environments more flexible for when they are used outside of mozilla-central. https://reviewboard.mozilla.org/r/119000/#review121100 ::: tools/lint/eslint/eslint-plugin-mozilla/package.json:31 (Diff revision 1) > "globals": "^9.14.0", > "ini-parser": "^0.0.2", > "sax": "^1.1.4" > }, > "engines": { > "node": ">=4.2.0" Can you bump this to 6.9.1 while you're here.
Attachment #8845858 -
Flags: review?(dtownsend) → review+
Assignee | ||
Comment 3•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8845858 [details] Bug 1346167 - Make the eslint-plugin-mozilla environments more flexible for when they are used outside of mozilla-central. https://reviewboard.mozilla.org/r/119000/#review121100 > Can you bump this to 6.9.1 while you're here. Yes, definitely, I meant to do that.
Comment hidden (mozreview-request) |
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a8d751c288e4 Make the eslint-plugin-mozilla environments more flexible for when they are used outside of mozilla-central. r=mossop
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a8d751c288e4
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•6 years ago
|
Product: Testing → Firefox Build System
Updated•5 years ago
|
Version: Version 3 → 3 Branch
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•