1346215 - Firefox instacrashing startup in [@ DWriteFontTypeface::onFilterRec ]

Status: VERIFIED FIXED

(Core :: Graphics: Text, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: Regression

STR:
1. Instacrash after update from (2017-03-09) to (2017-03-10) build.

Crashlog reports:
https://crash-stats.mozilla.com/report/index/035059b8-cceb-4d46-90cc-ffa0a2170310
https://crash-stats.mozilla.com/report/index/2c172630-7545-448d-ac79-da4662170310
https://crash-stats.mozilla.com/report/index/436bd156-8676-43de-b315-b7b242170310
https://crash-stats.mozilla.com/report/index/1edc9406-e989-462f-9203-baa742170310
https://crash-stats.mozilla.com/report/index/62f6c76a-3283-4c82-8344-4d1a82170310

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

"Speedy" Regression window (mozilla-central)
Good:
https://ftp.mozilla.org/pub/firefox/nightly/2017/03/2017-03-09-03-02-16-mozilla-central/

Bad:
https://ftp.mozilla.org/pub/firefox/nightly/2017/03/2017-03-10-03-02-05-mozilla-central/

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c40ca7a1bdd93632c6bdc5e23bd33d984d508b19&tochange=9b0f116a58d6adb6934f50bcf220cc3ca4343d60


Probably caused by:
c8bfaf1927b6	Daniel Holbert — Bug 1291483 part 2: Use UniquePtr/MakeUnique more thoroughly in chain-of-custody for gfxFont::mVerticalMetrics. r=jfkthame
5a0c4791eef5	Daniel Holbert — Bug 1291483 part 1: Use 'MakeUnique' instead of 'new' to allocate gfxFont::mGlyphChangeObservers. r=jfkthame

Comment 3

[Carsten Book [:Tomcat]]

this got backed out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=528e9dbbb882db0b32792d44b5be9cc539afa1a8 and retriggering the nightlys now.


Marking this one as "fixed" and comment in Bug 1291483

Comment 4

[Marcia Knous [:marcia]]

Adding the mac signature to this bug so it gets picked up in crash stats.

Comment 5

[Codacoder]

https://bugzilla.mozilla.org/show_bug.cgi?id=1346238#c2

Comment 6

[Marcia Knous [:marcia]]

(In reply to Marcia Knous [:marcia - use ni] from comment #4)
> Adding the mac signature to this bug so it gets picked up in crash stats.

Actually, even though the same build ID it is a different bug, so removing.

Comment 8

[Daniel Holbert [:dholbert]]

How sure are we that the backout backed out the right thing and fixed this?

Last night aja was hitting this crash locally (using autoland treeherder builds), and he initially suspected the same cause (my patches in Bug 1291483), but he was later able to reproduce with a build from *just before* that landed, which (unless he made a mistake) means the backout that we've done here won't help!

He ended up isolating  bug 1345222 (which also landed last night, also font-related) as the cause -- see bug 1345222 comment 28.

Unless we're absolutely sure that the backout we've already done fixes it, we should probably backout bug 1345222 as well and retrigger nightlies.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

I've pushed a backout of bug 1345222 to m-c. Retriggering nightlies again as well.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Actually, there's no way bug 1345222 is causing the Linux/OSX crashes as it touched Windows-only code. Bug 1056516 looks like a way more likely culprit for those. I have no clue if it's *also* responsible for the Windows crashes, so I'm going to leave the rest backed out to play it safe.

https://hg.mozilla.org/mozilla-central/rev/a8d497b09753c91783b68c5805c64f34a2f39629

Hopefully *these* nightlies are in better shape across all platforms!

Comment 11

[Codacoder]

I just downloaded latest nightly - still instacrashing. How long should I wait?

Comment 12

[Ryan VanderMeulen [:RyanVM]]

More than 30 minutes. We'll un-freeze nightly updates when there's a build worth trying.

Comment 13

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #8)
> aja [...] ended up isolating  bug 1345222 (which also landed last night, also
> font-related) as the cause -- see bug 1345222 comment 28.

--> Updating "blocks" field to reflect this.

(aja triple-checked this using treeherder builds, and verified that local crashes have the same signature as this bug here)

Comment 15

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I also retested now it on inbound builds to confirm this
and the real culprit is indeed bug #1345222.

@ Daniel Holbert [:dholbert], Carsten Book [:Tomcat], Ryan VanderMeulen [:RyanVM] - I'm very sorry for the confusion.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

All of the Nightly re-spins have finished (finally) and updates are un-frozen.

Comment 17

[Codacoder]

Not crashing here anymore (Win7)

Comment 18

[Daniel Holbert [:dholbert]]

(In reply to Virtual_ManPL [:Virtual] - (please needinfo? me) from comment #15)
> I also retested now it on inbound builds to confirm this
> and the real culprit is indeed bug #1345222.

(Thanks for double-checking, and for filing this bug & getting traction in the first place!)

(In reply to Codacoder from comment #17)
> Not crashing here anymore (Win7)

Woohoo, thanks for verifying. I'm glad we got this sorted out & fixed.