Closed Bug 1346335 Opened 7 years ago Closed 11 months ago

Is "new" LinkedIn incompatible with "new" Firefox? (Gecko Profiler overhead)

Categories

(Core :: JavaScript Engine: JIT, defect)

52 Branch
defect

Tracking

()

RESOLVED INACTIVE
Performance Impact low
Tracking Status
platform-rel --- +

People

(Reporter: bugzilla.10.dggeorge, Unassigned, NeedInfo)

References

Details

(Keywords: perf, Whiteboard: [platform-rel-Linkedin])

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170302120751

Steps to reproduce:

I used LinkedIn, in its horrible 2017 incarnation (they removed much of its robust desktop functionality to make it work like a mobile version), with 30+ open tabs in my browser.


Actual results:

Ever since FF 51 and LinkedIn 2017 hit my computer - at about the same time - in a matter of a couple hours, sometimes 30 minutes or less, the browser becomes so sludgy in its response that, for sanity, I'd have to quit FF.  Quitting it would generally NOT properly shut FF down - it would still be running five minutes later until stopped with task manager.  Memory usage would not be glaringly high - maybe 0.9-1.3 gigs, on a computer with four gigs of RAM.  But the browser would be unusable.  So two bad things: (1) sluggish performance, and (2) exiting FF doesn't really exit it; it has to be separately and manually stopped through task manager.

By the way, the earlier bug https://bugzilla.mozilla.org/show_bug.cgi?id=1335482 documents this, except now I am curious about whether LinkedIn is the cause.  Roughly half my open tabs are LinkedIn.


Expected results:

Short form: (1) Firefox should run all day and be responsive, even with 30+ tabs open, and a lot of LinkedIn usage; (2) Exiting FF should, in a matter of a few seconds, terminate it and all related processes from running on my computer.

*** Today I started a new FF profile, just for grins.  I ported over my browsing history and cookies, but none of the extensions/add-ons (including I currently have nothing set for blocking ads).  I have also not gone even once into LinkedIn.  My browser has been stable and responsive for 4+ hours so far.  Not sure if this is because of the new profile, or because of no LinkedIn, or because of both.
This issue also happens with a clean profile? https://support.mozilla.org/kb/profile-manager-create-and-remove-firefox-profiles.
Keywords: perf
As described in the final paragraph of the original post, when I started today with a new and clean profile, and have so far refrained from using LinkedIn, the browser is exhibiting the best behavior I've seen in a long time.

On Monday I will resume using LinkedIn, and hope the stability will continue.
After less than 4-5 hours of use of Firefox today, new profile, no ad-blocking, LinkedIn usage (but not heavy by any means), the symptoms described in the original post reappeared.

Firefox slowed down so badly, and was so non-responsive, that I had to close it.

And closing it the regular way still left the process running in Task Manager, so I had to terminate the process via TM to get it to stop so I could restart.

To me this confirms that LinkedIn's 2017 version is at least partly to blame.  Does anyone else here use LinkedIn much?  I'd be interested to see how it behaves for you.
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0

I have tested your issue on latest Firefox release v52.0 and managed to reproduce it. I have opened www.linkedin.com and other 40 tabs and started to browse through linkedin. The browser crashed. Crash ID bp-05f8281d-18e3-4dcd-9c46-bd3462170315
Blocks: 1330193
Status: UNCONFIRMED → NEW
Component: Untriaged → JavaScript Engine: JIT
Ever confirmed: true
Product: Firefox → Core
(In reply to Vlad Bacia-Mociran [:VladB] from comment #4)
> User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
> Firefox/52.0
> 
> I have tested your issue on latest Firefox release v52.0 and managed to
> reproduce it. I have opened www.linkedin.com and other 40 tabs and started
> to browse through linkedin. The browser crashed. Crash ID
> bp-05f8281d-18e3-4dcd-9c46-bd3462170315

You seem to be running the profiler. Can you make sure the profiler is not running when trying to reproduce this issue?
Blocks: QF-Websites
platform-rel: --- → ?
Whiteboard: [platform-rel-Linkedin]
Whiteboard: [platform-rel-Linkedin] → [platform-rel-Linkedin][qf:p1]
(In reply to Hannes Verschore [:h4writer] from comment #5)
> You seem to be running the profiler. Can you make sure the profiler is not
> running when trying to reproduce this issue?

Without the Gecko Profiler I cannot reproduce the issue.
Summary: Is "new" LinkedIn incompatible with "new" Firefox? → Is "new" LinkedIn incompatible with "new" Firefox? (Gecko Profiler overhead)
Flags: needinfo?(mstange)
When the browser becomes sluggish, can you capture a profile so that we might get an idea of why it's sluggish?
Flags: needinfo?(mstange) → needinfo?(bugzilla.10.dggeorge)
We're hitting this crash: https://hg.mozilla.org/releases/mozilla-release/annotate/44d6a57ab554/js/src/jit/JitFrames.cpp#l3060

Kannan, any idea what might be going wrong?
Flags: needinfo?(kvijayan)
Whiteboard: [platform-rel-Linkedin][qf:p1] → [platform-rel-Linkedin][qf:p3]
Well, the jit stackwalker is seeing a frame type it is not expecting, so it doesn't know how to move forward.  This is either due to a new frame type being added, or something else in the stackwalk going wrong and dumping us into random stack memory that we can't figure out.

Making a new bug for the profiler crash.
Flags: needinfo?(kvijayan)
This sounds like something sstangl already tracked down once before.
Flags: needinfo?(sstangl)
I think Steve is thinking of Bug 1330193.
Flags: needinfo?(sstangl)
I cannot comment on the underlying system, but this has been troubling me, also.

Today, I installed Firefox portable 51.0.1 (Windows 7-64 bit), and LinkedIn works without the major slowdown that is present in the 52.* versions.

LinkedIn is not the only site / application that is affected, but it is the quickest to demonstrate the problem. All you have to do is log in to LinkedIn.
platform-rel: ? → +
Performance Impact: --- → P3
Whiteboard: [platform-rel-Linkedin][qf:p3] → [platform-rel-Linkedin]
Severity: normal → S3
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.