Closed Bug 1346370 Opened 7 years ago Closed 7 years ago

Uncomment out ThreeWayMerger.swift code when Swift Optimizations work on Xcode 8.3

Categories

(Firefox for iOS :: Build & Test, enhancement, P1)

Product:
Firefox for iOS
Component:
Build & Test
Platform:
Other
iOS
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Iteration:
1.19
Tracking Flags:
Tracking Status
fxios 8.0+ ---

People

(Reporter: sleroux, Assigned: sleroux)

References

Details

(Whiteboard: [MobileCore]) 

To work around the swift optimization issues with ThreeWayMerger.swift, we had to comment out some code and exclude the source file from the Sync target in order for it to compile. If this change lands on master we'll need to uncomment out the code and add back in the source file so we can get bidirectional bookmark syncing working.
tracking-fxios: ? → 8.0+
Priority: -- → P1
Iteration: --- → 1.19
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
The commenting out patch never landed on master and only lives on the v7.x. Marking as resolved.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.