Closed
Bug 1346604
Opened 7 years ago
Closed 5 years ago
Cross-compilation glue for dump_syms for Mac doesn't know about x86_64h architecture
Categories
(Toolkit :: Crash Reporting, enhancement)
Tracking
()
RESOLVED
WORKSFORME
Tracking | Status | |
---|---|---|
firefox55 | --- | affected |
People
(Reporter: mstange, Unassigned)
Details
Attachments
(1 file)
This only really matters if you want to use dump_syms to dump symbols from native macOS libraries, and you cross-compile your dump_syms on Linux or with emscripten. Ted, is this the right place for the patch, or should I go straight to chromium / breakpad upstream?
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
This is the part of breakpad we haven't forked yet so it should go to upstream possibly. I've got another couple of patches I'm pushing upstream so we can try to have all of them landed and then I'll pull from upstream again.
Reporter | ||
Comment 3•7 years ago
|
||
Sounds good.
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8846371 [details] Bug 1346604 - Make the cross-compilation glue for dump_syms Mac handle x86_64h. .mielczarek https://reviewboard.mozilla.org/r/119430/#review123910 Yeah, if you can submit this upstream I can review and land it there. It's sort of a pain but the instructions are here: https://chromium.googlesource.com/breakpad/breakpad/+/master/#Getting-started-from-master
Attachment #8846371 -
Flags: review?(ted) → review+
Comment 6•5 years ago
|
||
Oops, I now realize that it did get fixed. The dump_syms I just compiled from current code at https://github.com/google/breakpad/tree/master/src/tools/mac/dump_syms handles this problem correctly.
Flags: needinfo?(mstange)
Reporter | ||
Comment 7•5 years ago
|
||
Oh yeah, I think Ted upstreamed this for me.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•