1346812 - Use standard pad functions in aboutTelemetry.js

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P4)

Description

[flyingrub]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170227084058

Steps to reproduce:

We use some custom padding code in aboutTelemetry.js:
https://dxr.mozilla.org/mozilla-central/search?q=path%3Atoolkit%2Fcontent%2FaboutTelemetry+pad+ext%3Ajs+ext%3Ajsm&redirect=false




Actual results:

JS now has standard padding functions though:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/padStart
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/padEnd


Expected results:

We should update the code to use them.

Comment 1

[flyingrub]

Attachment: Bug 1346812 - Use standard pad functions in aboutTelemetry.js

Review commit: https://reviewboard.mozilla.org/r/119684/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119684/

Comment 2

[Georg Fritzsche [:gfritzsche]]

Thanks for the initiative.
I assigned it to you and gave you bug editing rights - you can assign the bug to yourself in the future.

Comment 3

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8846671 [details]
Bug 1346812 - Use standard pad functions in aboutTelemetry.js

https://reviewboard.mozilla.org/r/119684/#review121548

This looks good, thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/446bc40870fe
Use standard pad functions in aboutTelemetry.js r=gfritzsche

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out eslint failures (new temporary policy for autoland to not fix things with follow-up pushes):

https://hg.mozilla.org/integration/autoland/rev/d983cb91c5a48243adcd13187f4ae9f623f3d0d0

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=446bc40870fecc7ec49f1ae8b3aa6f6b2a62a56e&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://queue.taskcluster.net/v1/task/GTDPf6-ATDimiImrnchSJA/runs/0/artifacts/public/logs/live_backing.log

TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/toolkit/content/aboutTelemetry.js:178:34 | A space is required after ','. (comma-spacing) 

flyingrub, can you also add your email address to your hg identity, please? This makes it easier to e.g. track your checkins.

Comment 6

[Georg Fritzsche [:gfritzsche]]

You can run eslint with e.g.: mach eslint toolkit/components/telemetry

Comment 7

[flyingrub]

Comment on attachment 8846671 [details]
Bug 1346812 - Use standard pad functions in aboutTelemetry.js

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/119684/diff/1-2/

Comment 8

[flyingrub]

It should be fixed. Thanks for the tip :gfritzsche :)

Comment 9

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8846671 [details]
Bug 1346812 - Use standard pad functions in aboutTelemetry.js

https://reviewboard.mozilla.org/r/119684/#review122936

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a68031fd18af
Use standard pad functions in aboutTelemetry.js r=gfritzsche

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a68031fd18af