1346911 - Report an error when a top level protocol has a delete message

Status: NEW

(Core :: IPC, enhancement, P3)

Description

[Andrew McCreight [:mccr8]]

type.py checks to make sure that non-top-level protocols have a delete message, but it doesn't check that top level protocols don't have delete messages. Instead (as in bug 1345977) we seem to just generate an empty delete message.

The existing check is:
        if not (p.decl.type.hasDelete or p.decl.type.isToplevel()):
            self.error(
                p.loc,
                "destructor declaration `%s(...)' required for managed protocol `%s'",
                _DELETE_MSG, p.name)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1346911 - Report an error when a top level protocol has a delete message.

Review commit: https://reviewboard.mozilla.org/r/119860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119860/

Comment 2

[Andrew McCreight [:mccr8]]

Here's a first pass at this. As you can see, there are a ton of test protocols that declare delete. Maybe it actually did something when we had a state machine? There were a lot of "DEAD: __delete__()" annotations in those files.

PVRManager.ipdl is the only non-test file that does so.

The next step is to audit the dozen or so test protocols in the error/ subdirectory, to figure out which ones need to have __delete__() removed, and then double check that they fail for the right reason once the __delete__ is removed.

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

Looks like http://searchfox.org/mozilla-central/rev/571c1fd0ba0617f83175ccc06ed6f3eb0a1a8b92/ipc/ipdl/ipdl/lower.py#3733-3735 and http://searchfox.org/mozilla-central/rev/571c1fd0ba0617f83175ccc06ed6f3eb0a1a8b92/ipc/ipdl/ipdl/lower.py#3751-3753 can be removed or turned into asserts after this.

Comment 4

[Andrew McCreight [:mccr8]]

Ah, nice! I wondered why the delete message cases were empty.

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 8846860 [details]
Bug 1346911 - Report an error when a top level protocol has a delete message.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/119860/diff/1-2/