Closed Bug 1347155 Opened 7 years ago Closed 7 years ago

WebRender clips should not share ServoScrollRootIds

Categories

(Core :: Graphics: WebRender, defect)

Product:
Core
Component:
Graphics: WebRender
Version:
Other Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: mrobinson, Assigned: mrobinson)

Details

Attachments

(1 file)

Pass None as the argument to push_scroll_layer
3.58 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/56.0.2924.76 Chrome/56.0.2924.76 Safari/537.36
When creating clipping / scrolling nodes the ServoScrollRootId is used to scroll and track scrolling position of nodes from the client. Previously it wasn't a problem to share these ids if they were unused, but WebRender has changed to the point where they must all be unique.
Attachment #8847118 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/563b634aec44
WebRender clips should not share ServoScrollRootIds. r=jrmuizel
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/mozilla-central/rev/563b634aec44
Assignee: nobody → mrobinson
status-firefox55: --- → fixed
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: