Closed
Bug 1347728
Opened 7 years ago
Closed 7 years ago
blocklist-clients.js:370 updateJSONBlocklist resource://gre/modules/services-common/blocklist-clients.js:370
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
RESOLVED
FIXED
mozilla55
People
(Reporter: kjozwiak, Assigned: leplatrem)
Details
Attachments
(1 file)
When pinging the new blocklisting server [1] under Windows, you'll get the following error message in the browser console every time: Win error 3 during operation open on file C:\Users\kjozwiak\AppData\Roaming\Mozilla\Firefox\Profiles\a9f9f6lj.default\blocklists/addons.json.tmp (The system cannot find the path specified.) blocklist-clients.js:370 updateJSONBlocklist resource://gre/modules/services-common/blocklist-clients.js:370:5 throw self-hosted:1140:9 TaskImpl_run resource://gre/modules/Task.jsm:320:42 bound TaskImpl_run self-hosted:961:17 process resource://gre/modules/Promise-backend.js:925:21 walkerLoop resource://gre/modules/Promise-backend.js:806:7 bound walkerLoop self-hosted:917:17 bound bound walkerLoop self-hosted:917:17 This doesn't affect m-b and m-r as they're still using the older blocklisting server [2]. STR: * install the latest m-c or m-a * devtools.chrome.enabled;true & extensions.logging.enabled;true under about:config * open the browser console and ping the blocklist server via: Components.classes["@mozilla.org/extensions/blocklist;1"].getService(Components.interfaces.nsITimerCallback).notify(null); [1] https://blocklists.settings.services.mozilla.com/v1/blocklist/3/ [2] https://blocklist.addons.mozilla.org/blocklist/3/
Updated•7 years ago
|
Component: Blocklisting → Add-ons Manager
Comment 1•7 years ago
|
||
looking into who to direct the block list to - quinto - only in central/aurora... so it was in 53
Flags: needinfo?(aswan)
Comment 2•7 years ago
|
||
Mathieu, this looks like code you've touched recently, can you take a look at this bug? (And should it be in some different component?)
Flags: needinfo?(aswan) → needinfo?(mathieu)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → mathieu
Flags: needinfo?(mathieu)
Assignee | ||
Comment 3•7 years ago
|
||
Thanks for reporting! Indeed I can see that the latest folder level in the path contains a forward slash. I can fix that.
Comment hidden (mozreview-request) |
Reporter | ||
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8850444 [details] Bug 1347728 - Fix JSON dump of blocklists https://reviewboard.mozilla.org/r/123026/#review125494
Attachment #8850444 -
Flags: review?(kjozwiak) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 6•7 years ago
|
||
seems this need a final review/ship-it before we can push via the autolander
Flags: needinfo?(mathieu)
Keywords: checkin-needed
Comment 7•7 years ago
|
||
Mathieu, I sorry your ping on IRC but I'm not familiar enough with this code to review it. Perhaps Mark Goodwin could?
Flags: needinfo?(mgoodwin)
Comment hidden (mozreview-request) |
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8850444 [details] Bug 1347728 - Fix JSON dump of blocklists https://reviewboard.mozilla.org/r/123026/#review134418
Attachment #8850444 -
Flags: review?(mgoodwin) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(mathieu)
Keywords: checkin-needed
Comment 11•7 years ago
|
||
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/816a2cc1254a Fix JSON dump of blocklists r=kjozwiak,mgoodwin
Keywords: checkin-needed
Comment 12•7 years ago
|
||
Backed out for failing xpcshell's test_blocklist_certificates.js on Windows: https://hg.mozilla.org/integration/autoland/rev/fb33533158025961b84732331fc4b882c7662dc1 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=816a2cc1254aff32e4f38b9aa49bf0e18c85a045&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=93055368&repo=autoland 09:58:32 INFO - TEST-START | services/common/tests/unit/test_blocklist_certificates.js 09:58:33 WARNING - TEST-UNEXPECTED-FAIL | services/common/tests/unit/test_blocklist_certificates.js | xpcshell return code: 0 09:58:33 INFO - TEST-INFO took 1299ms 09:58:33 INFO - >>>>>>> 09:58:33 INFO - PID 1192 | JavaScript strict warning: resource://services-common/kinto-http-client.js, line 1344: ReferenceError: reference to undefined property "initializer" 09:58:33 INFO - PID 1192 | JavaScript strict warning: resource://services-common/kinto-http-client.js, line 961: ReferenceError: reference to undefined property "initializer" 09:58:33 INFO - PID 1192 | JavaScript strict warning: resource://services-common/kinto-http-client.js, line 339: ReferenceError: reference to undefined property "initializer" 09:58:33 INFO - (xpcshell/head.js) | test MAIN run_test pending (1) 09:58:33 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2) 09:58:33 INFO - (xpcshell/head.js) | test MAIN run_test finished (2) 09:58:33 INFO - running event loop 09:58:33 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "initializer"" {file: "resource://services-common/kinto-http-client.js" line: 1344}]" 09:58:33 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "initializer"" {file: "resource://services-common/kinto-http-client.js" line: 961}]" 09:58:33 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "initializer"" {file: "resource://services-common/kinto-http-client.js" line: 339}]" 09:58:33 INFO - services/common/tests/unit/test_blocklist_certificates.js | Starting test_something 09:58:33 INFO - (xpcshell/head.js) | test test_something pending (2) 09:58:33 INFO - (xpcshell/head.js) | test run_next_test 0 finished (2) 09:58:33 INFO - PID 1192 | ************************* 09:58:33 INFO - PID 1192 | A coding exception was thrown and uncaught in a Task. 09:58:33 INFO - PID 1192 | Full message: TypeError: NetworkError when attempting to fetch resource. 09:58:33 INFO - PID 1192 | Full stack: loadFile@resource://services-common/blocklist-clients.js:124:30 09:58:33 INFO - PID 1192 | loadDumpFile@resource://services-common/blocklist-clients.js:123:12 09:58:33 INFO - PID 1192 | syncCollection@resource://services-common/blocklist-clients.js:217:39 09:58:33 INFO - PID 1192 | TaskImpl_run@resource://gre/modules/Task.jsm:319:42 09:58:33 INFO - PID 1192 | _do_main@c:\\slave\\test\\build\\tests\\xpcshell\\head.js:211:5 09:58:33 INFO - PID 1192 | _execute_test@c:\\slave\\test\\build\\tests\\xpcshell\\head.js:546:5 09:58:33 INFO - PID 1192 | @-e:1:1 09:58:33 INFO - PID 1192 | ************************* 09:58:33 INFO - PID 1192 | JavaScript strict warning: resource://services-common/kinto-http-client.js, line 531: ReferenceError: reference to undefined property "headers" 09:58:33 INFO - PID 1192 | JavaScript strict warning: resource://services-common/kinto-http-client.js, line 1018: ReferenceError: reference to undefined property "headers" 09:58:33 INFO - "CONSOLE_MESSAGE: (error) [JavaScript Error: "NetworkError when attempting to fetch resource." {file: "resource://services-common/blocklist-clients.js" line: 124}] 09:58:33 INFO - loadFile@resource://services-common/blocklist-clients.js:124:30 09:58:33 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:319:42 09:58:33 INFO - TaskImpl@resource://gre/modules/Task.jsm:277:3 09:58:33 INFO - asyncFunction@resource://gre/modules/Task.jsm:252:14 09:58:33 INFO - Task_spawn@resource://gre/modules/Task.jsm:166:12 09:58:33 INFO - loadDumpFile@resource://services-common/blocklist-clients.js:123:12 09:58:33 INFO - syncCollection@resource://services-common/blocklist-clients.js:217:39 09:58:33 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:319:42 09:58:33 INFO - _do_main@c:\\slave\\test\\build\\tests\\xpcshell\\head.js:211:5 09:58:33 INFO - _execute_test@c:\\slave\\test\\build\\tests\\xpcshell\\head.js:546:5 09:58:33 INFO - @-e:1:1 09:58:33 INFO - " 09:58:33 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "headers"" {file: "resource://services-common/kinto-http-client.js" line: 531}]" 09:58:33 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "headers"" {file: "resource://services-common/kinto-http-client.js" line: 1018}]" 09:58:33 WARNING - TEST-UNEXPECTED-FAIL | services/common/tests/unit/test_blocklist_certificates.js | test_something - [test_something : 77] false == true 09:58:33 INFO - c:/slave/test/build/tests/xpcshell/tests/services/common/tests/unit/test_blocklist_certificates.js:test_something:77 09:58:33 INFO - _run_next_test@c:\slave\test\build\tests\xpcshell\head.js:1554:9 09:58:33 INFO - run@c:\slave\test\build\tests\xpcshell\head.js:703:9 09:58:33 INFO - _do_main@c:\slave\test\build\tests\xpcshell\head.js:211:5 09:58:33 INFO - _execute_test@c:\slave\test\build\tests\xpcshell\head.js:546:5 09:58:33 INFO - @-e:1:1 09:58:33 INFO - exiting test 09:58:33 INFO - Unexpected exception 2147500036 09:58:33 INFO - undefined 09:58:33 INFO - exiting test 09:58:33 INFO - <<<<<<<
Flags: needinfo?(mathieu)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 15•7 years ago
|
||
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e35828da3a2e Fix JSON dump of blocklists r=kjozwiak,mgoodwin
Keywords: checkin-needed
Updated•7 years ago
|
Flags: needinfo?(mgoodwin)
Comment 16•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e35828da3a2e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment 17•7 years ago
|
||
Mark 54 won't fix as this is late for Beta54.
You need to log in
before you can comment on or make changes to this bug.
Description
•