1348209 - Make wr_renderer_readback() as to handle both GL and GLES

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Make wr_renderer_readback() as to handle both GL and GLES

Comment 2

[Sotaro Ikeda [:sotaro]]

The functions were borrowed from https://github.com/servo/webrender/pull/984.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8848390 [details] [diff] [review]
patch - Make wr_renderer_readback() as to handle both GL and GLES

Review of attachment 8848390 [details] [diff] [review]:
-----------------------------------------------------------------

r+ but in the future I will r- any review request without a commit message, so please make sure to add commit messages going forward.

::: gfx/webrender_bindings/src/bindings.rs
@@ +56,5 @@
>  check_ffi_type!(_namespace_id_repr struct IdNamespace as (u32));
>  
> +const GL_FORMAT_BGRA_GL: gl::GLuint = gl::BGRA;
> +
> +const GL_FORMAT_BGRA_GLES: gl::GLuint = gl::BGRA_EXT;

nit: remove the empty line between these two

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Make wr_renderer_readback() as to handle both GL and GLES

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Make wr_renderer_readback() as to handle both GL and GLES

Comment 6

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2265e179245749c52c384c1e2be78453615d1ec2

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/8680b14ea3d0
Make wr_renderer_readback() as to handle both GL and GLES r=kats

Comment 8

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/8680b14ea3d0