1348610 - The Stub installer is installing 32 bit Firefox on 64 bit Windows.

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Caspy7]

I've seen multiple reports from users and now tested myself and another developer.

0) Be on 64 bit Windows
1) Go to https://www.mozilla.org/en-US/firefox/new/ 
2) Click on "Firefox for Other Platforms and Languages" 
3) Click "Windows 64-bit"
4) Download/install/run installer

Expect to install 64 bit version of Firefox.

Actually install 32 bit version of Firefox (as verified in the About dialog).

Seems like it's a bug in the installer, but in the mean time we also need to fix the page offering the links.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

When I tried to reproduce this (using Chrome on 64bit Windows 10) at 1) I got sent to 
  https://www.mozilla.org/en-US/firefox/new/?f=102
which is from a funnelcake test (bug 1332726). That would provide a 32 bit installer because the test only has those. ni cmore for this.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

At 3, the link I get is https://download.mozilla.org/?product=firefox-stub&os=win64&lang=en-US&attribution_code=c291cmNlPXd3dy5tb3ppbGxhLm9yZyZtZWRpdW09cmVmZXJyYWwmY2FtcGFpZ249KG5vdCBzZXQpJmNvbnRlbnQ9KG5vdCBzZXQpJnRpbWVzdGFtcD0xNDg5ODk1NDUy&attribution_sig=73d16e73f441ba4e9611a98920c1bda740e8c52c5fc069bf312e75ed5cccec55. In bug 797208 the stub installer gets smart and will download the 32 or 64 bit full installer depending on the OS it is running on. However it only does this for Firefox 53, and we have 52.0.1 on release right now. ni pmac for this, it does look like a regression from bug 1344220.

Comment 3

[Molly Howell (she/her) (no longer active)]

The link described in comment 0 should not currently be directing to stub installers at all, because the stub for release 52 cannot download 64-bit builds. That option was added in 53, and even then it isn't set by default until 55. The link should be to a full installer.

(not sure if this is the right component, but at least it's the right product)

Comment 5

[Paul [:pmac] McLanahan]

Working on this now. Which channel(s) should get a stub installer for 64bit windows? Only Nightly?

Comment 6

[Molly Howell (she/her) (no longer active)]

Right now, yes. The current plan is to allow that to ride the 55 train.

Comment 7

[Paul [:pmac] McLanahan]

Attachment: Link to Github pull-request: https://github.com/mozilla/bedrock/pull/4729

This is the fix. It's already been given an r+ by :agibson. As soon as tests pass in CI I'll merge it and start the production push.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/ea657fcb18c74f3012bf0d7dd71267b8f4a6802f
Fix bug 1348610: Win64 stub installer only for Nightly

Stub installer for win64 is scheduled to ride the Fx 55 train,
we should not enable it for more channels (aurora, beta, release)
until we're told that smart switching has been enabled in the stub.

https://github.com/mozilla/bedrock/commit/436d87f986412fc0d23393d40b730e12fb10e138
Merge pull request #4729 from pmac/remove-win64-stub-installer-1348610

Fix bug 1348610: Win64 stub installer only for Nightly

Comment 9

[Paul [:pmac] McLanahan]

Fixed in prod. Update here if you see any instances more instances of the issue.

Comment 10

[Chris More [:cmore]]

Hi everyone.

Sorry being late to the game. Thee was also an email thread related to this.

Should I change the targeting conditions for the funnelcake to only target Win32 or exclude Win64 or will the fix that :pmac pushed resolve this directly? 

Please let me know.

Comment 11

[Paul [:pmac] McLanahan]

I believe our fix will fix it since win64 no longer gets a stub-installer link at all. Does that sound right to you Chris?

Comment 12

[Chris More [:cmore]]

(In reply to Paul [:pmac] McLanahan from comment #11)
> I believe our fix will fix it since win64 no longer gets a stub-installer
> link at all. Does that sound right to you Chris?

Will it work like this?

English Win64 visitor go to /firefox/new/, they will get redirected to ?f=101 or ?f102 from Optimizely, but they ?f= funnelcake helper won't tell bouncer to give them a stub installer and they will get a normal win64 full installer instead. Is that how it will work for the win64 audience if they get pulled into the funnelcake redirect?

Comment 13

[Paul [:pmac] McLanahan]

Currently the only way to get a 64bit download for release from the /new/ page is to click on the "Firefox for other platforms and languages". So if you go to:

https://www.mozilla.org/en-US/firefox/new/?f=101

The link for win64 in the modal is unaffected.

Comment 14

[Chris Peterson [:cpeterson]]

(In reply to Chris More [:cmore] from comment #10)
> Should I change the targeting conditions for the funnelcake to only target
> Win32 or exclude Win64 or will the fix that :pmac pushed resolve this
> directly? 

About 74% [1] of Firefox users are running Win64 OS, so excluding them will reduce your Funnelcake's eligible user population, if that matters. But if a user that asks for 64-bit Firefox 52 and gets 32-bit will be upset.

[1] https://metrics.mozilla.com/firefox-hardware-report/#goto-os-and-architecture

Comment 15

[Kohei Yoshino [:kohei]]

Does this 64-bit issue on still exist in the installer?

Comment 16

[Kohei Yoshino [:kohei]]

Never mind, 55 is the current target as said earlier.