1348854 - Webextension pop-up style displayed while installing legacy add-ons from about:addons search list

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: 2017-03-20_1701.png

[Affected versions]:
Firefox 55.0a1 (2017-03-20)
Firefox 54.0a2 (2017-03-20)


[Affected platforms]:
Windows 10 64-bit
Ubuntu 16.04 32-bit

[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Create extensions.webextPermissionPrompts and set it to true.
3.Navigate to about:addons -> Extensions tab.
4.Search for a legacy add-on using the search bar displayed in the top right corner of the page.
5.Choose one item from the list and click “Install” button.


[Expected Results]:
As was discussed in https://bugzilla.mozilla.org/show_bug.cgi?id=1335697#c19, no pop-up should be displayed for legacy add-ons while installing from about:add-ons search list.


[Actual Results]:
- Webextension pop-up, which correspond for a webextension with no permissions, appears while installing a legacy add-on from about:addons search list.
- See attached screenshot

[Regression Range]:
Last good revision: 69d2cf007cdc13cf2bd33370b1732d4f969fd9af
First bad revision: c7935d540027158ef1bf8e1c0e69af6b2eb9df93
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=69d2cf007cdc13cf2bd33370b1732d4f969fd9af&tochange=c7935d540027158ef1bf8e1c0e69af6b2eb9df93

Comment 1

[Vasilica Tamas, QA [:vtamas]]

I’m not sure which bug regressed this issue, Andrew do you have any idea?

Comment 2

[Andrew Swan [:aswan]]

The comment linked above was about the post-install notifications.  I don't think we ever talked about whether there should be a confirmation during the isntall process for legacy add-ons.  Markus, what say you?

Comment 3

[Markus Jaritz [:designakt] (UX)]

It is strange that we decided to not do the post-install notification for legacy but no do the pre-install confirmation...
I'd rather not have that pop-up show for legacy extensions to be consistent with our previous decision.

Comment 4

[Nathan Froyd [:froydnj]]

Is this something we need to be tracking for release?

Comment 5

[Andy McKay]

No need to track, this is a new feature.

Comment 6

[Andrew Swan [:aswan]]

This is new but we've changed the behavior by flipping the pref on by default.  I'm marking 54 as unaffected since it doesn't occur there with the default settings.

Its easy to fix though, I'll get the patch together today.  I don't think its a big deal but it probably should be tracking.

[Tracking Requested - why for this release]:
With bug 1342142 we have unintentionally hanged the flow for installs from the search page, this bug is to fix it.

Comment 7

[Marcia Knous [:marcia]]

Tracking 55+ for the reasons in Comment 6.

Comment 8

[Andrew Swan [:aswan]]

Attachment: Bug 1348854 Don't show permissions prompt for legacy addons installed from search

Review commit: https://reviewboard.mozilla.org/r/124776/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124776/

Comment 9

[Andrew Swan [:aswan]]

The patch is simple, a test wouldn't be too much work but I'm at a work week at the moment and won't have a chance to write one for a bit.  Given the short lifetime remaining for legacy add-ons maybe we should just land this as-is?

Comment 10

[Robert Helmer [:rhelmer]]

Comment on attachment 8852582 [details]
Bug 1348854 Don't show permissions prompt for legacy addons installed from search

https://reviewboard.mozilla.org/r/124774/#review127372

I agree, we don't need to worry about testing since it's just a few releases we need to care about it.

Comment 11

[Robert Helmer [:rhelmer]]

Comment on attachment 8852582 [details]
Bug 1348854 Don't show permissions prompt for legacy addons installed from search

https://reviewboard.mozilla.org/r/124774/#review127374

Comment 12

[Robert Helmer [:rhelmer]]

Comment on attachment 8852582 [details]
Bug 1348854 Don't show permissions prompt for legacy addons installed from search

https://reviewboard.mozilla.org/r/124776/#review127376

Comment 13

[Andrew Swan [:aswan]]

Comment on attachment 8852582 [details]
Bug 1348854 Don't show permissions prompt for legacy addons installed from search

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/124776/diff/1-2/

Comment 14

[Andrew Swan [:aswan]]

Comment on attachment 8852582 [details]
Bug 1348854 Don't show permissions prompt for legacy addons installed from search

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/124776/diff/2-3/

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43c03ad7e9c1
Don't show permissions prompt for legacy addons installed from search r=rhelmer

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/43c03ad7e9c1

Comment 17

[Vasilica Tamas, QA [:vtamas]]

Confirm that this issue is fixed on Firefox 55.0a1 (2017-04-19) under Windows 10 64-bit and Ubuntu 16.04 32-bit. The pop-up is no longer displayed while installing legacy add-ons from Add-ons Manager search list.