1348880 - Create Initial Conduit Demo

Status: RESOLVED FIXED

(Conduit :: General, enhancement)

Description

[David Walsh :davidwalsh]

* create pipeline demo project in conduit, conduitdemo
* create docker-compose.yml, call other project dirs
* get hg extension code from vct into new docker container


Acceptance:

* docker-compose run hg push http://[stagingserver]/[createcommitcommand]
* commitindex service prints out log message stating it received POST

Comment 1

[David Walsh :davidwalsh]

Attachment: Conduit: Create the initial conduit demo (Bug 1348880).

This conduit demo starts the hg server, starts the commitindex service, loads and enables VCT mercurial extensions, and proves that the mercurial server's commitindex prints out a log as it receives a POST

Review commit: https://reviewboard.mozilla.org/r/122008/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122008/

Comment 2

[David Walsh :davidwalsh]

Comment on attachment 8849170 [details]
Conduit:  Create the initial conduit demo (Bug 1348880).

https://reviewboard.mozilla.org/r/122008/#review124004

Instructions for testing:


Terminal 1:
$ docker-compose run demo /bin/sh

Terminal 2:
$ hg clone http://hgserver:8080/testrepo
$ cd testrepo

$ hg help # See "conduit" and "reviewboard" listed under extensions
$ curl http://hgserver:8080/testrepo/commitindex # See JSON to prove our extension works

$ touch blah.js
$ hg add blah.js
$ hg commit -m "This is a test commit"
$ hg push

$ hg conduit --rev . http://hgserver:8080/testrepo # View 400 error in both terminals

Flip to Terminal 1, view POST

Comment 3

[Māris Fogels [:mars] (please needinfo)]

Comment on attachment 8849170 [details]
Conduit:  Create the initial conduit demo (Bug 1348880).

https://reviewboard.mozilla.org/r/122008/#review124030

::: conduitdemo/docker-compose.yml:20
(Diff revision 1)
> +    ports:
> +      - "8080:8080"

I don't think we need to expose ports here.  Developers can create a docker-compose.override.yml file to expose whatever ports they want for ease of development.

::: conduitdemo/docker-compose.yml:55
(Diff revision 1)
> +    ports:
> +      - "8888:80"

I don't think we need to expose ports here.  Developers can create a docker-compose.override.yml file to expose whatever ports they want for ease of development.

::: conduitdemo/docker-vct-hg/Dockerfile:1
(Diff revision 1)
> +FROM alpine

We should pin alpine to major.minor to avoid problems like we encountered with nodejs in the autoland service.

::: conduitdemo/docker-vct-hg/Dockerfile:1
(Diff revision 1)
> +FROM alpine

Needs a MPL copyright license stanza

Comment 4

[David Walsh :davidwalsh]

Comment on attachment 8849170 [details]
Conduit:  Create the initial conduit demo (Bug 1348880).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122008/diff/1-2/

Comment 5

[David Walsh :davidwalsh]

Comment on attachment 8849170 [details]
Conduit:  Create the initial conduit demo (Bug 1348880).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122008/diff/2-3/

Comment 6

[Māris Fogels [:mars] (please needinfo)]

Comment on attachment 8849170 [details]
Conduit:  Create the initial conduit demo (Bug 1348880).

https://reviewboard.mozilla.org/r/122008/#review124066

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/automation/conduit/rev/c462aef96eb2
Conduit:  Create the initial conduit demo . r=mars