1349051 - Intermittent browser_advanced_siteData.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=85068438&repo=autoland

https://queue.taskcluster.net/v1/task/WR_AL_gzRp2LtxPFzEjCzA/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Intermittent Failures Robot]

7 failures in 898 pushes (0.008 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 2
* mozilla-central: 2
* autoland: 2
* graphics: 1

Platform breakdown:
* linux32: 4
* linux64: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1349051&startday=2017-03-20&endday=2017-03-26&tree=all

Comment 2

[Geoff Brown [:gbrown]]

This has been failing for a few days but failure frequency spiked markedly yesterday, around the time the test was updated in bug 1335907. Failures are all Linux32/64-Debug.

Test durations for browser/components/preferences/in-content/tests/browser_advanced_siteData.js on mozilla-central,mozilla-inbound,autoland between 2017-03-14 and 2017-03-28
linux32/debug-chunked:          61.99 s (37.03 s - 89.69 s over 849 runs)
linux32/debug-e10s:             71.47 s (50.91 s - 89.69 s over 496 runs)
linux32/opt-chunked:            18.87 s (11.58 s - 31.23 s over 1110 runs)
linux32/opt-e10s:               23.91 s (17.84 s - 31.23 s over 394 runs)
linux64/asan-chunked:           35.56 s (21.82 s - 54.33 s over 792 runs)
linux64/asan-e10s:              42.61 s (28.36 s - 54.33 s over 409 runs)
linux64/debug-chunked:          60.63 s (35.73 s - 89.05 s over 1012 runs)
linux64/debug-e10s:             67.78 s (48.32 s - 89.05 s over 695 runs)
linux64/opt-chunked:            19.25 s (11.12 s - 38.34 s over 620 runs)
linux64/opt-e10s:               23.01 s (16.28 s - 38.34 s over 316 runs)
linux64/pgo-chunked:            16.51 s (9.69 s - 29.34 s over 653 runs)
linux64/pgo-e10s:               19.87 s (12.76 s - 27.08 s over 344 runs)

It looks like the test was already running for about 70 seconds on average on linux32/64-debug before the recent change - it would not have taken much delay to start hitting the 90 second timeout frequently.

Zachary - Can you have a look at this? If the test cannot be optimized or split, a requestLongerTimeout(2) call should fix this.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

We should split the test.

Looking at the changes from the commit, https://hg.mozilla.org/mozilla-central/diff/069b6372cc15/browser/components/preferences/in-content/tests/browser_advanced_siteData.js, there is nothing that shouldn't be there. The test now opens the privacy pane, which is longer than the advanced pane was and thus will take longer to load, hence the change in timeout rate.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1349051 - Split browser_advanced_siteData.js to browser_siteData.js and browser_siteData2.js since it was running too long.

Review commit: https://reviewboard.mozilla.org/r/125578/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125578/

Comment 5

[Intermittent Failures Robot]

33 failures in 146 pushes (0.226 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 13
* autoland: 12
* try: 3
* mozilla-central: 3
* oak: 2

Platform breakdown:
* linux32: 21
* linux64: 12

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1349051&startday=2017-03-31&endday=2017-03-31&tree=all

Comment 6

[Fischer [:Fischer]]

Comment on attachment 8853523 [details]
Bug 1349051 - Split browser_advanced_siteData.js to browser_siteData.js and browser_siteData2.js since it was running too long.

https://reviewboard.mozilla.org/r/125578/#review128324

Looks good. Thanks for helping on this.

Comment 7

[Intermittent Failures Robot]

86 failures in 845 pushes (0.102 failures/push) were associated with this bug in the last 7 days. 

This is the #18 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 42
* mozilla-inbound: 22
* mozilla-central: 12
* try: 5
* oak: 3
* mozilla-aurora: 1
* graphics: 1

Platform breakdown:
* linux32: 62
* linux64: 24

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1349051&startday=2017-03-27&endday=2017-04-02&tree=all

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c83ec472c2f4
Split browser_advanced_siteData.js to browser_siteData.js and browser_siteData2.js since it was running too long. r=Fischer

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c83ec472c2f4

Comment 10

[Intermittent Failures Robot]

23 failures in 147 pushes (0.156 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 9
* autoland: 8
* mozilla-central: 3
* try: 2
* graphics: 1

Platform breakdown:
* linux32: 15
* linux64: 8

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1349051&startday=2017-04-03&endday=2017-04-03&tree=all

Comment 11

[Intermittent Failures Robot]

26 failures in 867 pushes (0.03 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 9
* autoland: 8
* try: 3
* mozilla-central: 3
* graphics: 3

Platform breakdown:
* linux32: 18
* linux64: 8

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1349051&startday=2017-04-03&endday=2017-04-09&tree=all

Comment 12

[Intermittent Failures Robot]

17 failures in 894 pushes (0.019 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 11
* try: 2
* mozilla-central: 2
* mozilla-inbound: 1
* graphics: 1

Platform breakdown:
* linux32: 10
* linux64: 7

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1349051&startday=2017-04-10&endday=2017-04-16&tree=all

Comment 13

[Intermittent Failures Robot]

5 failures in 883 pushes (0.006 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 3
* mozilla-central: 1
* autoland: 1

Platform breakdown:
* linux32: 3
* linux64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1349051&startday=2017-04-24&endday=2017-04-30&tree=all

Comment 14

[Geoff Brown [:gbrown]]

:jaws - Your change to split in-content/tests/browser_advanced_siteData.js was very effective - thank you! - but there are still some time outs from in-content-old/tests/browser_advanced_siteData.js. Should the same change be applied there, or could that test be skipped perhaps?

Comment 15

[Jared Wein [:jaws] (please needinfo? me)]

We should do the same split for the in-content-old test too, but at this point it should be in a separate bug. I didn't do it in this bug because I thought the timeouts were only in the combined (re-org'd) preferences.

Comment 16

[Jared Wein [:jaws] (please needinfo? me)]

I filed bug 1361170 for splitting up the in-content-old version.

Comment 17

[Intermittent Failures Robot]

2 failures in 814 pushes (0.002 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* try: 2

Platform breakdown:
* linux32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1349051&startday=2017-06-12&endday=2017-06-18&tree=all