1349094 - Panel appears in wrong place (goes off-screen) when its anchor moves up / down

Status: NEW

(Toolkit :: PopupNotifications and Notification Bars, defect)

Description

[684sigma]

I have a problem with Firefox Beta 53.
Sometimes panels appear in a wrong place.
It happens unpredictably, however, I noticed one specific scenario when it happens

1. Put Downloads button before location bar
2. In maximized window, click on that button
3. Press Win+Left to change window size. Then you can even press Win+Up to restore window size

Result: Only right 30px of the panel are visible (panel is appears in a wrong place).
Expected: The whole panel should be visible.

Comment 1

[684sigma]

Happens with all buttons with panels, for example Pocket. Doesn't happen in Firefox ESR 45.

Comment 2

[YF (Yang)]

(In reply to 684sigma from comment #1)
> Happens with all buttons with panels, for example Pocket. Doesn't happen in
> Firefox ESR 45.

I can see the issue in Fx45.8.0esr, with Win+Right key * 2.

Comment 3

[684sigma]

Attachment: bug 1349094 + bug 1349096 = UX regression, by reporter.webm

(In reply to YF (Yang) from comment #2)
> (In reply to 684sigma from comment #1)
> > Happens with all buttons with panels, for example Pocket. Doesn't happen in
> > Firefox ESR 45.
> 
> I can see the issue in Fx45.8.0esr, with Win+Right key * 2.

This is not what I did. However, the panel never went off-screen, and that's why this bug is UX regression.

This bug is especially bad in conjunction with Bug 1349096, which is still unconfirmed, watch attached video.

Comment 4

[684sigma]

Mozregression-gui generated this regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5b38cc764e9012ec544cc3b150c35db706e34ced&tochange=d280a7a149bba92ecdb59b9de0a0336c336de889
->
1109868 - XUL popups with an anchor element should hide when the anchor loses its visibility and/or frame
https://bugzilla.mozilla.org/show_bug.cgi?id=1109868

Comment 5

[Timothy Nikkel (:tnikkel)]

Setting flags based on regressing bug from comment 4.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late to fix in 53. We might still be able to take a patch in 54.

Comment 7

[Mike Taylor [:miketaylr]]

I can't get this to reproduce in Nightly 57 w/ PhotonUI. Does it still repro for you 684sigma?

Comment 8

[Neil Deakin]

This is a case where the OS moves the window for us, but we don't respond in any special manner, when the normal handling would be to close the popup when the parent window moves.

This popup has also explicitly set autoPosition to false, so it wouldn't get adjusted anyway.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

For more information, please visit auto_nag documentation.