remove --with-macos-sdk option as it's no longer needed for cross builds
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox55 affected)
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | affected |
People
(Reporter: froydnj, Unassigned)
Details
This option was added for cross-Mac builds, but our cross-Mac configs don't use this option, preferring instead to setup -isysroot in C*FLAGS directly. I'm guessing this is because --with-macos-sdk doesn't get processed soon enough to apply to some of the compiler checks in moz.configure (?).
|
||
Updated•6 years ago
|
|
||
Comment 1•3 years ago
|
||
Following the instructions at:
https://firefox-source-docs.mozilla.org/setup/macos_build.html
I downloaded the 10.12 SDK, copied it to the correct location, and added:
ac_add_options --with-macos-sdk=$HOME/.mozbuild/macos-sdk/MacOSX10.12.sdk
to mozconfig. However, when running ./mach build I got an error saying:
mozbuild.configure.options.InvalidOptionError: --with-macos-sdk is not available in this configuration
I commented out the line from mozconfig and tried again. This time it worked. So... yeah. I don't know where to post a bug about the macOS build instructions, and this is basically the only Bugzilla search result for --with-macos-sdk.
|
|
||
Comment 2•3 years ago
|
||
I should clarify: I'm running macOS Big Sur 11.2.1.
|
||
Comment 3•3 years ago
|
||
mozbuild.configure.options.InvalidOptionError: --with-macos-sdk is not available in this configuration
For this error message to show up, you have to either not be building on or for mac (but comment 2 says the contrary) or be building with --enable-artifact-builds, which doesn't require compilation and thus doesn't require a sdk.
That said, since this bug was filed, thing have changed, and the option is recommended for people who want to point to a specific SDK that is not the one that would be picked otherwise, rather than setting C*FLAGS manually.
|
|
||
Comment 4•3 years ago
|
||
Thanks for the explanation. I did add --enable-artifact-builds because the build output suggested I do so. I actually created a separate bug regarding this error message in the context of insufficient documentation, which is probably more applicable.
Description
•