Closed
Bug 1349335
Opened 7 years ago
Closed 7 years ago
Use the grid colours for the grid cell and area fills
Categories
(DevTools :: Inspector, defect, P3)
DevTools
Inspector
Tracking
(firefox55 verified)
VERIFIED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | verified |
People
(Reporter: gl, Assigned: micah)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The fill color for the grid cell and area highlights should follow the design spec.
Reporter | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Assignee: gl → tigleym
Comment hidden (mozreview-request) |
Reporter | ||
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8873687 [details] Bug 1349335 - Use new colours for the grid cell and area fills. https://reviewboard.mozilla.org/r/145082/#review149242
Attachment #8873687 -
Flags: review?(gl)
Comment hidden (mozreview-request) |
Reporter | ||
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8873687 [details] Bug 1349335 - Use new colours for the grid cell and area fills. https://reviewboard.mozilla.org/r/145082/#review149732
Attachment #8873687 -
Flags: review?(gl) → review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/337dfcb8c30a Use the grid color for the grid cell and area fills. r=gl
Reporter | ||
Updated•7 years ago
|
Flags: qe-verify+
Summary: Use new colours for the grid cell and area fills → Use the grid colours for the grid cell and area fills
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/337dfcb8c30a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 7•7 years ago
|
||
Hello Micah. Does the fix affect the grid outline (that box model of the grid area from a webpage inside Layout)? I'm trying to figure out what to verify here.
Flags: needinfo?(tigleym)
Assignee | ||
Comment 8•7 years ago
|
||
(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #7) > Hello Micah. Does the fix affect the grid outline (that box model of the > grid area from a webpage inside Layout)? I'm trying to figure out what to > verify here. Hello! This fix affects the grid highlighter on the webpage and not the grid outline inside the Layout panel. When you hover over a grid cell in the grid outline, you should expect the highlighted cell's fill colour to be the same as the current colour palette of the grid (but transparent).
Flags: needinfo?(tigleym)
Comment 9•7 years ago
|
||
(In reply to Micah Tigley [:micah] from comment #8) > (In reply to Bogdan Maris, QA [:bogdan_maris] from comment #7) > > Hello Micah. Does the fix affect the grid outline (that box model of the > > grid area from a webpage inside Layout)? I'm trying to figure out what to > > verify here. > > Hello! This fix affects the grid highlighter on the webpage and not the grid > outline inside the Layout panel. When you hover over a grid cell in the grid > outline, you should expect the highlighted cell's fill colour to be the same > as the current colour palette of the grid (but transparent). Thanks! Confirming that this issues is verified fixed based on the testing done during pre-Beta signoff and testing done by me today using Fx 55.0 build 3 (after enabling 'devtools.gridinspector.showGridOutline' and 'devtools.layoutview.enabled') across platforms (Windows 10 64bit, macOS 10.12.5 and Ubuntu 16.04 32bit).
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•