Closed
Bug 1349354
Opened 7 years ago
Closed 7 years ago
Remove experimental SourceMapService (uses server-side source map support)
Categories
(DevTools :: General, enhancement, P3)
DevTools
General
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jryans, Assigned: tromey)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
In bug 670002, an experimental `SourceMapService` was added. The current state: * The service is off by default because of perf issues (bug 1289570) * This service uses server-side source map support * It's only used in the console (old and new) We're working towards client-side source maps, so we'll eventually want to remove this approach.
Assignee | ||
Comment 1•7 years ago
|
||
Let's not forget to remove the client side code that will be obsolete: location-store.js and source-map-service.js.
Depends on: 1359144
Assignee | ||
Comment 2•7 years ago
|
||
And resolveLocation in target.js, and the code in the tab actor, and likewise TabClient.
Assignee | ||
Comment 4•7 years ago
|
||
It's unclear if some of the existing server-side code is still in use. Certainly the style sheet code is. I think it's advisable to start with what's obviously unused and then delete more in a later bug.
Assignee: nobody → ttromey
Comment hidden (mozreview-request) |
Reporter | ||
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8867715 [details] Bug 1349354 - remove now-unused source-map-service; https://reviewboard.mozilla.org/r/139290/#review142596 Great, looks like you've removed everything that can be removed for now. For the server-side source mapping support in general, I'd say that should remain in place until the old debugger is removed, but I'm sure other arguments could be made...
Attachment #8867715 -
Flags: review?(jryans) → review+
Assignee | ||
Comment 7•7 years ago
|
||
Yeah, from my reading it requires removing the old debugger (or updating that to the client-side service) as well as parts of the inspector. I'll file a follow-up.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 10•7 years ago
|
||
eslint found an unused variable.
Assignee | ||
Comment 11•7 years ago
|
||
The source-map-url-service.js change was wrong - I think I misunderstood the situation when I wrote that module initially, since what is really happening is that generatedUrl is first computed by SpiderMonkey during parsing, then given to us via the actor. This isn't something we'll ever be removing. So, my next patch will just update the comment there.
Comment hidden (mozreview-request) |
Comment 13•7 years ago
|
||
Pushed by ttromey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fcc8c00308a1 remove now-unused source-map-service; r=jryans
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fcc8c00308a1
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•