1349541 - Tab Tray Menu label spacing in French is wrong

Status: VERIFIED FIXED

(Firefox for iOS :: Menu and Toolbar, defect, P1)

Description

[Emily Toop (:fluffyemily)]

Attachment: IMG_0414.png

In the French localization, the Settings menu option wraps incorrectly. The spacing may need to be adjusted.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This label is already shrunk down as much as possible. So we have two possibilities here:

- Use a different (shorter) word
- Include a hyphenation hint in Paramètres so that it is correctly broken.

Comment 2

[Delphine Lebédel [:delphine - Use needinfo]]

Moving to Théo so he can decide what to do in this case. Thanks!

Comment 3

[Théo Chevalier]

Paramètre<br>s is actually not the issue, it’s the 3-lines labels: “New private tab” and “Close all tabs”, some characters in the third line are cut-off.
For instance “onglets” reads “onqlets” since it is cut-off at the bottom (compare with the first “onglet” in “Nouvel onglet”)

Does that make more sense?

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Thanks Théo. This is really weird .. if there is a line spacing issue then this may also be happening for other locales. I'll try to run screenshots for some more locales to see what is going on here.

This bug has been marked for inclusion in 8.0

Comment 5

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Just a heads up, this PR adds some patterns to .gitignore to prevent all the non-English imported locales from showing up as uncommitted changes in Git. I don't think this causes any problems, but you would probably know better than I :-)

Comment 6

[Farhan Patel [:farhan]]

Attachment: Pull Request

Comment 7

[Farhan Patel [:farhan]]

Attachment: Pull Request

Comment 8

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/4c29abc404e94aa27c062b512633c67a2ebf796e

Landed on v8.x:

https://github.com/mozilla-mobile/firefox-ios/commit/799c673421c2496c44a62fb736d53d7e25c3bb3f

Comment 9

[Simon Basca [:SimonB]]

Verifying as fix on master 4538e6d3e and 8.0b3672. Tab Tray Menu is correctly displayed in French.