Closed
Bug 1349834
Opened 7 years ago
Closed 7 years ago
stylo: Remove eRestyle_SVGAttrAnimations declartion.
Categories
(Core :: CSS Parsing and Computation, enhancement, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: mantaroh, Assigned: boris)
Details
Attachments
(2 files, 2 obsolete files)
The stylo build failed because we removed the SVGAttrAnimationRuleProcessor on bug 1062106(bug 1062106, comment 81). So then I decided that I leave related restyle hint and remove this restyle hint from gecko and servo at this bug. Note that we should remove string definition from RestyleManager when we remove this restyle hint.[1] [1] https://dxr.mozilla.org/mozilla-central/rev/e03e0c60462c775c7558a1dc9d5cf2076c3cd1f9/layout/base/RestyleManager.cpp#411
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → boris.chiou
|
|
Assignee | |
Comment 1•7 years ago
|
||
OK, Looks like we only need to remove eRestyle_SVGAttrAnimations on stylo. I suppose we need to wait for the patches of bug 1062106 merged into m-c first. Fortunately, they are in autoland alredy.
|
|
Assignee | |
Updated•7 years ago
|
Summary: Remove eRestyle_SVGAttrAnimations declartion. → stylo: Remove eRestyle_SVGAttrAnimations declartion.
|
|
Assignee | |
Updated•7 years ago
|
Component: Layout → CSS Parsing and Computation
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8850818 -
Flags: review?(boris.chiou)
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8850816 [details] Bug 1349834 - Remove eRestyle_SVGAttrAnimations declartion. https://reviewboard.mozilla.org/r/123322/#review125848
Attachment #8850816 -
Flags: review?(xidorn+moz) → review+
|
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8850817 [details] Bug 1349834 - Update RESTYLE_STYLE_ATTRIBUTE to sync Gecko change. https://reviewboard.mozilla.org/r/123324/#review125850
Attachment #8850817 -
Flags: review?(xidorn+moz) → review+
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8850817 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8850818 -
Attachment is obsolete: true
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 9•7 years ago
|
||
|
||
Comment 10•7 years ago
|
||
Pushed by bchiou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b2a34dd3df40 Remove eRestyle_SVGAttrAnimations declartion. r=xidorn
|
||
Comment 11•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b2a34dd3df40
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Comment 12•7 years ago
|
||
Thank you Boris!
|
||
Updated•7 years ago
|
Priority: -- → P1
You need to log in
before you can comment on or make changes to this bug.
Description
•