1349841 - Don't show "Never For This Session" option in web notification permission prompts in PBM

Status: VERIFIED FIXED

(Firefox :: Site Identity, enhancement, P1)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Bug 1341742 added a dropdown for the secondary action of web notification permission prompts, with a "Never" option ("Never For This Session" in private browsing mode). We shouldn't show this in private browsing mode.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1349841 - Don't show "Never For This Session" option in web notification permission prompts in PBM.

Review commit: https://reviewboard.mozilla.org/r/122978/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122978/

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Johann, I started adding a test to browser_PermissionUI_prompts.js but it felt pretty messy without refactoring the file, so I  aborted mission banking on what you said in bug 1348257 comment 3 about adding tests for all permission prompts in a separate bug anyway. Let me know if you think that's reasonable.

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8850345 [details]
Bug 1349841 - Don't show "Never For This Session" option in web notification permission prompts in PBM.

https://reviewboard.mozilla.org/r/122978/#review125378

Thanks!

> I  aborted mission banking on what you said in bug 1348257 comment 3 about adding tests for all permission prompts in a separate bug anyway.

Makes sense to me.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7204bd900962
Don't show "Never For This Session" option in web notification permission prompts in PBM. r=johannh

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7204bd900962

Comment 7

[Hani Yacoub, Desktop QA]

Build ID: 20170329030240
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

Verified as fixed on Firefox Nightly 55.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.