Open Bug 1349931 Opened 7 years ago Updated 2 years ago

IPDLCompile::error() should check for an actual error

Categories

(Core :: IPC, enhancement, P3)

Product:
Core
Component:
IPC
Type:
enhancement

Tracking

()

People

(Reporter: mccr8, Unassigned)

Details

Bug 1345111 added a new failure condition, and included new tests for this failure condition (which pass!), but as seen in bug 1349350 this did not actually fail. The reason the unit tests did not catch this is because IPDLCompile::error() only checks for an error message in stderr. It should also check that the process failed.

The ok() method checks the following, so presumably something like the "not" of that is needed:
        return (not self.exception()
                and not self.error()
                and (0 == self.returncode))
Priority: -- → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.