1350444 - MozReview gets into a broken state if I click "Publish" on a review when Bugzilla is down

Status: RESOLVED INVALID

(MozReview Graveyard :: General, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: screencast of bug

See attached screencast.

Bugzilla is currently kinda-down (though it loads fine for already-logged-in users).  I thought that maybe I could still complete a MozReview review, but actually MozReview ends up in a broken state if I try to complete a review!

See attached screencast. If I click "Publish" on my review, the buttons all get grayed out!! (including "Finished Edit")   This leaves me with no way to dismiss the Edit Review overlay, and it leaves me with the sinking feeling that my review notes may have all just been horked...

Happily, I'm able to regain control if I adjust the r+/r- dropdown -- this forces the buttons to re-compute their enabled/disabled state, I guess.  But until I figured that out, this was pretty scary.

Comment 1

[Daniel Holbert [:dholbert]]

You can see the broken/sinking-feeling state from ~0:08 in my screencast.

I apply the workaround (tweaking r+/r- state) at ~0:15 in my screencast. But until that point, it's unclear what I can do (or whether anything is safe to do) to avoid losing state.

Comment 2

[Mark Côté [:mcote]]

Yeah I agree that behaviour is less than ideal.  Fwiw no information is lost.  What's happening under the hood is that a hook in our extension is called which updates Bugzilla.  This happens before anything is recorded in the Review Board database, so if an error happens (as in this case), all the information is still in the review-request draft object.  The error successfully bubbles, but for some reason the UI gets disabled.  A force-refresh also solves the problem.

Comment 3

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.