1350694 - Permaorange browser_blobFromFile.js | We have a file when Gecko 55 merges to aurora 2017-04-17

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Phil Ringnalda (:philor)]

e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=86490608&repo=try from https://treeherder.mozilla.org/#/jobs?repo=try&revision=a432e5adc397e465aa4884506a5d041ecb8b3d65 - apparently e10s-only, but on all platforms.

[Tracking Requested - why for this release]: merge permaorange, closed tree, sadness.

Comment 1

[Marcia Knous [:marcia]]

Tracking 55+ based on Comment 0.

Comment 2

[Andrea Marchesini [:baku]]

It seems that we don't have the separate file-content-process here. That test is for that. I suggest to disable the test.
Do you want me to write a patch?

Comment 3

[Phil Ringnalda (:philor)]

Attachment: set the pref

Nah, let's just set the pref that will keep the test working even when it isn't set by default anymore.

Note that although https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9722ff493373f0b7918571e6f659ab6871e2518 says this makes the test work, I just blindly copy-pasted that line from another test without actually knowing how pushPrefEnv is supposed to be used or what yield actually means :)

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8852181 [details] [diff] [review]
set the pref

Review of attachment 8852181 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/xhr/tests/browser_blobFromFile.js
@@ +2,5 @@
>  
>  add_task(function* test() {
> +  yield SpecialPowers.pushPrefEnv(
> +    {set: [["browser.tabs.remote.separateFileUriProcess", true]]}
> +  );

or enable: dom.file.createInChild

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/61493f82b7a1
set browser.tabs.remote.separateFileUriProcess in browser_blobFromFile.js so it will work even in non-Nightly builds, r=baku

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/61493f82b7a1