Closed
Bug 1350732
Opened 7 years ago
Closed 7 years ago
Set the pref to enable dom.storageManager in tests that depend on it being enabled
Categories
(Testing :: web-platform-tests, enhancement)
Testing
web-platform-tests
Tracking
(firefox-esr45 unaffected, firefox52 unaffected, firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox-esr45 | --- | unaffected |
| firefox52 | --- | unaffected |
| firefox-esr52 | --- | unaffected |
| firefox53 | --- | unaffected |
| firefox54 | --- | unaffected |
| firefox55 | --- | fixed |
People
(Reporter: philor, Assigned: philor)
Details
Attachments
(1 file)
|
2.39 KB,
patch
|
jgraham
:
review+
|
Details | Diff | Splinter Review |
dom.storageManager.enabled is only set for Nightly, so the armload of storage/ tests that depend on it being set to work need to set it to avoid permaorange when trunk merges to aurora on 2017-04-17.
|
Assignee | |
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=108db6e931a19a7fd2f442ec2c593381250cb8a2 probably says I got rid of all the typos on my second attempt.
|
|
Assignee | |
Updated•7 years ago
|
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
status-firefox54:
--- → unaffected
status-firefox55:
--- → affected
status-firefox-esr45:
--- → unaffected
status-firefox-esr52:
--- → unaffected
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8851412 [details] [diff] [review] Enable it Could also gave set this in a __dir__.ini file in testing/web-platform/meta/storage/
Attachment #8851412 -
Flags: review?(james) → review+
Pushed by philringnalda@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/63ff56600b67 Set the pref to enable dom.storageManager in tests that depend on it being enabled, r=jgraham
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/63ff56600b67
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
|
Assignee | |
Comment 5•7 years ago
|
||
I'll probably live to regret not using a __dir__.ini for all three pref-setting patches, but baby steps, baby steps.
|
|
Assignee | |
Comment 6•7 years ago
|
||
Living to regret it right now, that didn't take very long.
Pushed by philringnalda@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7d9c92e2215c set the pref to enable dom.storageManager in a __dir__.ini instead of playing Whac-A-Test
|
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7d9c92e2215c
You need to log in
before you can comment on or make changes to this bug.
Description
•