1351132 - Logging doesn't work properly in ChromiumCDMChild

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, enhancement, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

The logging in ChromiumCDMChild::OnSessionKeysChange() isn't properly logging the keyId; it's printing out a series of "%hX" instead of the keyId converted to hex.

e.g.:

2017-03-28 00:06:54.369000 UTC - [Main Thread]: D/GMP ChromiumCDMChild::OnSessionKeysChange(sid=B18F8D11FA2B742AC0DB4EF19DD3AFFC) keys={%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX=0,%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX=0,%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX=0}

I also had the string "WidevineVideoDecoder::Decode" in ChromiumCDMChild::RecvDecryptAndDecodeFrame(), which is misleading.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1351132 - Fix keystatus and decode logging in ChromiumCDMChild.

Review commit: https://reviewboard.mozilla.org/r/124036/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124036/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8851833 [details]
Bug 1351132 - Fix keystatus and decode logging in ChromiumCDMChild.

https://reviewboard.mozilla.org/r/124036/#review126554

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af6eb87cc3de
Fix keystatus and decode logging in ChromiumCDMChild. r=gerald

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/af6eb87cc3de