Closed
Bug 1351528
Opened 7 years ago
Closed 7 years ago
Streamline TracingMetadata
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(2 files)
4.75 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
8.06 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
I have a couple of clean-ups for TracingMetadata.
Assignee | ||
Comment 1•7 years ago
|
||
This patch: - Removes TRACING_EVENT_BACKTRACE, which is unused. - Removes TRACING_DEFAULT and replaces all its uses with TRACING_EVENT, because there is no difference in how those two are used. - Removes TRACING_TIMESTAMP, which is unused and also doesn't do anything different to TRACING_EVENT.
Attachment #8852296 -
Flags: review?(mstange)
Updated•7 years ago
|
Attachment #8852296 -
Flags: review?(mstange) → review+
Assignee | ||
Comment 2•7 years ago
|
||
"Metadata" regularly confuses me, because it suggests something complicated rather than a simple enum. This change also has the benefit of removing inconsistent capitalization ("Metadata" vs. "MetaData").
Attachment #8852299 -
Flags: review?(mstange)
Comment 3•7 years ago
|
||
Comment on attachment 8852299 [details] [diff] [review] (part 2) - Rename TracingMetadata as TracingKind Review of attachment 8852299 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Nicholas Nethercote [:njn] from comment #2) > This change also has the benefit of removing inconsistent capitalization > ("Metadata" vs. "MetaData"). Oh dear...
Attachment #8852299 -
Flags: review?(mstange) → review+
Assignee | ||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a04997cb00e9b907c3fc85c8ec1037cf5db611bd Bug 1351528 (part 1) - Streamline TracingMetadata. r=mstange. https://hg.mozilla.org/integration/mozilla-inbound/rev/198705c67281eb64995acc8329079f5dfaa09ad4 Bug 1351528 (part 2) - Rename TracingMetadata as TracingKind. r=mstange.
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a04997cb00e9 https://hg.mozilla.org/mozilla-central/rev/198705c67281
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee | ||
Updated•7 years ago
|
Summary: (part 1) - Streamline TracingMetadata → Streamline TracingMetadata
You need to log in
before you can comment on or make changes to this bug.
Description
•