Closed
Bug 1352035
Opened 7 years ago
Closed 7 years ago
Intermittent devtools/client/netmonitor/test/browser_net_html-preview.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_html-preview.js:37 - TypeError: document.querySelector(...) is null
Categories
(DevTools :: Netmonitor, defect, P1)
DevTools
Netmonitor
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: locke12456, Mentored)
References
Details
Attachments
(2 files)
Filed by: cbook [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=87526170&repo=mozilla-inbound https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win64/1490867362/mozilla-inbound_win8_64_test-mochitest-e10s-devtools-chrome-5-bm110-tests1-windows-build212.txt.gz
Comment 1•7 years ago
|
||
@Locke: this seems to be related to bug 1350229 you have been working on. Looks like we can remove the test. Honza
Flags: needinfo?(locke12456)
Priority: -- → P1
Assignee | ||
Comment 2•7 years ago
|
||
@Honza:Ok,I'll fix it. :) Can you assign this issue to me?
Flags: needinfo?(locke12456) → needinfo?(odvarko)
Comment 3•7 years ago
|
||
Done! Honza
Assignee: nobody → locke12456
Mentor: odvarko
Status: NEW → ASSIGNED
Flags: needinfo?(odvarko)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8853232 [details] Bug 1352035 - Removed test case for preview-panel. https://reviewboard.mozilla.org/r/125298/#review127902 You need to remove also: * html_content-type-test-page.html * const CONTENT_TYPE_URL = ... (in head.js) Honza
Attachment #8853232 -
Flags: review?(odvarko)
Assignee | ||
Comment 7•7 years ago
|
||
Ok, I got it. Thank you,@honza
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8853370 [details] Bug 1352035 - Removed the dependency on the test case preview-panel settings. https://reviewboard.mozilla.org/r/125488/#review128044 Thanks! Honza
Attachment #8853370 -
Flags: review?(odvarko) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: intermittent-failure → checkin-needed
Comment 11•7 years ago
|
||
Autoland can't push this because the first patch doesn't have sufficient review for landing.
Keywords: checkin-needed
Assignee | ||
Comment 12•7 years ago
|
||
Sorry, I have no idea how to operate it. should I reset these commit and push again? many thanks!
Flags: needinfo?(odvarko)
Comment 13•7 years ago
|
||
mozreview-review |
Comment on attachment 8853232 [details] Bug 1352035 - Removed test case for preview-panel. https://reviewboard.mozilla.org/r/125298/#review128542
Attachment #8853232 -
Flags: review+
Comment 14•7 years ago
|
||
(In reply to Locke Chen from comment #12) > Sorry, I have no idea how to operate it. should I reset these commit and > push again? > many thanks! No need to push again, I just R+ the first patch. Honza
Flags: needinfo?(odvarko)
Keywords: checkin-needed
Comment 15•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d5c4cf3eeb84 Removed test case for preview-panel. r=Honza https://hg.mozilla.org/integration/autoland/rev/9cb3f1aee967 Removed the dependency on the test case preview-panel settings. r=Honza
Keywords: checkin-needed
Assignee | ||
Comment 16•7 years ago
|
||
(In reply to Jan Honza Odvarko [:Honza] from comment #14) > (In reply to Locke Chen from comment #12) > > Sorry, I have no idea how to operate it. should I reset these commit and > > push again? > > many thanks! > No need to push again, I just R+ the first patch. > > Honza So that's how it is. I understand. Thank you.
Comment 17•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d5c4cf3eeb84 https://hg.mozilla.org/mozilla-central/rev/9cb3f1aee967
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•