1352161 - Nightly - "Add <search engine name here>" (from the search bar) doesn't work.

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Lyubomir [:mystiquewolf]]

When you visit for example Facebook, Wikipedia, YouTube or so, a green + appears in the search bar. When you type something it shows predictions along with the "Add <search engine name here>" button. That button doesn't work on click.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1352161 - Fix search engine installation from searchbar.

Review commit: https://reviewboard.mozilla.org/r/125226/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125226/

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8853158 [details]
Bug 1352161 - Fix search engine installation from searchbar.

https://reviewboard.mozilla.org/r/125226/#review128496

Thanks! And sorry I introduced this mistake while landing the patch from bug 1214284.

I wish this had test coverage, but I'm not requiring it here as writing a test shouldn't block fixing this currently completely broken piece of UI.

Comment 3

[Mark Banner (:standard8)]

Aryx, is there any reason this hasn't landed yet, or was it just missed?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7971ea016601
Fix search engine installation from searchbar. r=florian

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Sorry, I wanted to add a testcase before landing, but didn't find time yet, so I landed the patch and opened bug 1356145 for adding the test case.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7971ea016601

Comment 9

[Sayed [:LiquidO2]]

I have reproduced this bug with Firefox Nightly 55.0a1(2017-03-31)in 64 bit Ubuntu 16.04

This bug is now verified as fixed in Latest Nightly 55.0a1

Build ID 	20170414100243
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170412]

Comment 11

[Madhuri]

[bugday-20170419]

status-ff55 : FIXED & VERIFIED.

The issue is no longer reproducible on Firefox latest Nightly [BuildID : 20170419030223 , 55.0a1(2017-04-19)(32 bit)]. 
Tests were performed under Windows 10 X 64.

Comment 12

[balaji2198]

I am not able to reproduced this bug 

Os: Windows 7 32 bit
Browser : Firefox Nightly 55.0a1

bugday-[20170426]

Comment 13

[Oana Botisan, Desktop QA]

I managed to reproduce this bug using Nightly from 2017-03-30 on Windows 10. Then I tested it on the latest Nightly and Firefox 55.0b13 and the bug is not reproducing anymore. I believe this is fixed.

Comment 14

[Oana Botisan, Desktop QA]

(In reply to Oana Botisan from comment #13)
> I managed to reproduce this bug using Nightly from 2017-03-30 on Windows 10 x64.
> Then I tested it on the latest Nightly and Firefox 55.0b13 and the bug is
> not reproducing anymore. I believe this is fixed.

I also tested this bug on Ubuntu 16.04 LTS x64 and on macOS 10.11 using Firefox 55.0b13 and the bug is not reproducing. I still think that the issues is fixed.

Comment 15

[Bogdan Maris, Desktop QA]

Thanks all for testing. Marking accordingly.