Closed Bug 1352189 Opened 7 years ago Closed 7 years ago

Creating a tab of a deleted container is permitted

Categories

(WebExtensions :: General, defect, P2)

52 Branch
x86_64
Linux
defect

Tracking

(firefox57 fix-optional)

RESOLVED WORKSFORME
Tracking Status
firefox57 --- fix-optional

People

(Reporter: jkt, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: triaged)

When I use:

browser.tabs.create({url: confirmUrl, cookieStoreId: `firefox-container-2`})

Where I have deleted container 2, the browser opens the tab in a non container, I personally think this should be an exception as it might make developers easily open up privacy issues where they didn't check the containerId.

In my own use case it actually makes the code a lot more complex as I don't currently have the contextualIdentities api.

The contextualIdentities api coming in 53 will allow me to check for this however I would prefer to reduce code complexity and errors.

I would also push for using the userContextId instead of/also for creating tabs and referencing them.
I forgot to mention the created tab actually has the correct cookieStoreId rather than default.

This prevents me implementing the fix for this in web extensions in 52.
Priority: -- → P2
Whiteboard: triaged
Based on your comment 1, is this still valid?
Flags: needinfo?(jkt)
Yeah I think this got fixed with the changes in 57. Lets close this.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(jkt)
Resolution: --- → WORKSFORME
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.