Closed
Bug 1352369
Opened 7 years ago
Closed 7 years ago
Delete unused CSS after RectHighlighter was removed
Categories
(DevTools :: Inspector, enhancement)
DevTools
Inspector
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: pbro, Assigned: pbro)
Details
(Whiteboard: [bugday-20170426])
Attachments
(1 file)
In bug 1335691 we removed the RectHighlighter, but we forgot to also delete the CSS for it. The CSS is here: http://searchfox.org/mozilla-central/rev/72fe012899a1b27d34838ab463ad1ae5b116d76b/devtools/server/actors/highlighters.css#261-267 So it's really not a lot, but we should still remove it.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8853357 [details] Bug 1352369 - Delete unused RectHighlighter CSS; https://reviewboard.mozilla.org/r/125476/#review128502 Looks good to me! Good catch!
Attachment #8853357 -
Flags: review?(zer0) → review+
Pushed by pbrosset@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e0eb9f9895e7 Delete unused RectHighlighter CSS; r=zer0
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e0eb9f9895e7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 5•7 years ago
|
||
I have reproduced this on Firefox Nightly according to (2017-03-31) Fixing bug is verified on Latest Nightly--Build ID : (20170430030208),User Agent: Mozilla/5.0 (Windows NT 6.1; rv:55.0) Gecko/20100101 Firefox/55.0 Tested OS-- Windows7 32bit [bugday-20170426]
Updated•7 years ago
|
Whiteboard: [bugday-20170426]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•