Closed
Bug 1352389
Opened 7 years ago
Closed 7 years ago
Having nsAutoScriptBlocker in SetAttr and mozAutoDocUpdate in SetAttrAndNotify means most of the attribute sets end up creating script runners
Categories
(Core :: DOM: Core & HTML, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(2 files)
9.41 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
10.09 KB,
patch
|
Details | Diff | Splinter Review |
...because of the stuff EndUpdate() does.
Assignee | ||
Comment 1•7 years ago
|
||
Commit message missing. It could be: -m "Bug 1352389, don't push extra script blocker on stack when setting attributes, r=bz"
Attachment #8853409 -
Flags: review?(bzbarsky)
Comment 2•7 years ago
|
||
Comment on attachment 8853409 [details] [diff] [review] patch How about we also have a "mozAutoDocUpdate&" arg to SetAttrAndNotify, so that it's impossible to call without having one on the stack? r=me with that.
Attachment #8853409 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•7 years ago
|
||
That is what I had initially, but then realized I need the composed doc. I think there are rare enough callers for SetAttrAndNotify so I'm not too worried. But I can add the param I had back.
Comment 4•7 years ago
|
||
> That is what I had initially, but then realized I need the composed doc.
Yes, I meant pass both.
Assignee | ||
Comment 5•7 years ago
|
||
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/30fe7c61b5db don't push extra script blocker on stack when setting attributes, r=bz
Assignee | ||
Comment 7•7 years ago
|
||
Backing out. Either this or another patch caused some issues.
Assignee | ||
Updated•7 years ago
|
Keywords: leave-open
Assignee | ||
Comment 8•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae5cee559eeb2d82bbb4fefb1ac85930c291d533
Assignee | ||
Updated•7 years ago
|
Keywords: leave-open
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fde6f9f9ef00 don't push extra script blocker on stack when setting attributes, r=bz
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fde6f9f9ef00
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•