1352398 - use raw link to revisions instead of a revision number in the talos regression template

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

When filing a talos regression, we have a template which generates a bug for us.  This is great, but a complain today in Bug 1352085 seems like an easy fix:

(In reply to igoldan from comment #0)
> Talos has detected a Firefox performance regression from push
> 76ad1c764e5c626b20b87099fe9b822e21dc23e9.

Can you give an actual link to hg.m.o in future? If one person does it, it
saves everyone else having to manually copy, figure out the link, paste and go.


in this case it would be:
https://hg.mozilla.org/mozilla-central/rev/76ad1c764e5c626b20b87099fe9b822e21dc23e9

Comment 1

[William Lachance (:wlach)]

Shruti, do you want to take this one too? (whenever you have time)

Treeherder's repository object has a function we can use to generate this: getPushLogHref

If you run:

git grep getPushLog

You'll see a bunch of examples of us using it (including several in related code in Perfherder). So I think all we need to do is modify the fixtures here to replace "revision" with "revisionHref":

treeherder/perf/fixtures/performance_bug_templates.yaml

And then pass the argument in from the perfherder alerts code (I'll let you find it)

Comment 2

[Shruti Jasoria [:ShrutiJ]]

I'll take this one too.

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] SJasoria:Bug_1352398 > mozilla:master

Comment 4

[Shruti Jasoria [:ShrutiJ]]

Comment on attachment 8857336 [details] [review]
[treeherder] SJasoria:Bug_1352398 > mozilla:master

I hope the changes which I've made are good.

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8857336 [details] [review]
[treeherder] SJasoria:Bug_1352398 > mozilla:master

Could you make one small adjustment? Sorry for not mentioning it earlier.

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ec967845072493ad67ded0151ba2a50188e1589e
Bug 1352398 - use raw link to revisions instead of a revision number in the talos regression template (#2337)