Closed
Bug 1352563
Opened 7 years ago
Closed 7 years ago
Build Customizable UI for Focus Promotion
Categories
(Firefox for iOS :: Browser, enhancement, P1)
Tracking
()
RESOLVED
FIXED
Iteration:
1.20
People
(Reporter: sdaswani, Assigned: bmunar)
Details
(Whiteboard: [MMA] [MobileCore])
Attachments
(8 files)
This basically looks like an ad rectangle at the bottom of the screen.
Flags: needinfo?(randersen)
Summary: Build Custom UI for Focus Promotion → Build Customizable UI for Focus Promotion
We need more info on how to structure the promo for customization.
Create a LP variable as a dictionary that contains all the customizable elements: - background color - Top Text - Button Text - Button 'deep link' (URL to open another app or a screen in current app)
Robin, will you be able to specify the background color of the Promo UI as a six-character hex string, e.g., 0xFF13FC ?
Flags: needinfo?(randersen)
Assignee | ||
Comment 6•7 years ago
|
||
Actually, we can just use the RGB int. I think Robin knows what that is. We already have the extension in the code!
Comment 7•7 years ago
|
||
Colors specs were attached to the Trello card (I usually do it here but we were using Trello, so…) The hex and RGB color is #9012FE (alpha 40) and R144 G14 B254 A40 https://trello-attachments.s3.amazonaws.com/5876537a515b328f9da83ada/58c82d61513e6cbd2b0aaa96/7cd935ff55f6beb796b50b0038fcc58c/MMA-iOS-MVP-1-Layout-Specs.png and I'll attach here as well.
Flags: needinfo?(randersen)
Comment 8•7 years ago
|
||
Thanks for the specs Robin. And +1 to using the RGB int Bryan (e.g., R144 G14 B254 A40).
Assignee | ||
Comment 10•7 years ago
|
||
You know what, just kidding, the hex number would be fine -- sorry about that! No need for RGBs
Reporter | ||
Comment 11•7 years ago
|
||
Bryan how does the Hex number encapsulate the alpha setting?
Reporter | ||
Comment 12•7 years ago
|
||
Robin, should we also templatize the text color so we can handle different light/dark backgrounds? Also Bryan is still checking on how to incorporate Alpha into the Hex String.
Flags: needinfo?(randersen)
Flags: needinfo?(bmunar)
Assignee | ||
Comment 13•7 years ago
|
||
http://stackoverflow.com/questions/15852122/hex-transparency-in-colors
Flags: needinfo?(bmunar)
Comment 14•7 years ago
|
||
(In reply to Susheel Daswani from comment #12) > Robin, should we also templatize the text color so we can handle different > light/dark backgrounds? Yes, we should! See attached.
Flags: needinfo?(randersen)
Comment 15•7 years ago
|
||
Comment 16•7 years ago
|
||
Comment 17•7 years ago
|
||
Comment 18•7 years ago
|
||
Comment 19•7 years ago
|
||
Updated•7 years ago
|
Priority: -- → P2
Whiteboard: [mma] → [MMA] [MobileCore]
Updated•7 years ago
|
Iteration: --- → 1.20
Priority: P2 → P1
Reporter | ||
Comment 20•7 years ago
|
||
Merged in https://github.com/mozilla-mobile/firefox-ios/pull/2606/commits/cf540eb129150875d9b980a471eff8972ee6b51a#diff-3c6707ca508c97b210b46eab979e2667
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•