Closed Bug 1353050 Opened 7 years ago Closed 7 years ago

WasmSignalHandlers.cpp should use __sun instead of SOLARIS

Categories

(Core :: JavaScript Engine, defect)

52 Branch
Unspecified
Other
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: petr.sumbera, Assigned: petr.sumbera)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170323105023

Steps to reproduce:

JS build no longer defines SOLARIS macro (this disappeared somewhere between versions 45 and 52).

WasmSignalHandlers.cpp contains one condition where it's really needed and the condition should be probably changed to use pre-defined compiler macro (as it's used there for many other OSes).
Attached patch Bug1353050.patchSplinter Review
Attachment #8854043 - Flags: review?(luke)
Attachment #8854043 - Flags: review?(luke) → review+
Component: Untriaged → JavaScript Engine
OS: Unspecified → Other
Product: Firefox → Core
Keywords: checkin-needed
Assignee: nobody → petr.sumbera
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/054b05e1b8f7
WasmSignalHandlers.cpp should use __sun instead of SOLARIS. r=luke
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/054b05e1b8f7
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: