Closed
Bug 1353181
Opened 7 years ago
Closed 7 years ago
Make nsStringBuffer's reference count use the minimum memory synchronization needed
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
Attachments
(1 file)
|
5.99 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
This is the same optimization made for ThreadSafeAutoRefCnt in bug 1277709. However, nsStringBuffer uses a 32-bit reference count all the time, so it can't easily use ThreadSafeAutoRefCnt. MozReview-Commit-ID: LpB3xaYbaEE
|
Assignee | |
Updated•7 years ago
|
Component: XPCOM → String
|
|
Assignee | |
Comment 1•7 years ago
|
||
This is the same optimization made for ThreadSafeAutoRefCnt in bug 1277709. However, nsStringBuffer uses a 32-bit reference count all the time, so it can't easily use ThreadSafeAutoRefCnt. MozReview-Commit-ID: LpB3xaYbaEE
Attachment #8854185 -
Flags: review?(nfroyd)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8854185 [details] [diff] [review] Make nsStringBuffer's reference count use the minimum memory synchronization needed Review of attachment 8854185 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the comment in IsReadonly().
Attachment #8854185 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=50f3c56e5af5be0e01c02a67496ae5da91f7a8ac&group_state=expanded looks pretty green (though not *quite* done yet).
|
|
Assignee | |
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6f0b34e87f26826fb65c9889d6d1f24fc6f200c Bug 1353181 - Make nsStringBuffer's reference count use the minimum memory synchronization needed. r=froydnj
|
|
Assignee | |
Comment 5•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/19c4e80bee84eb2515f71df3649423245d0c13d5 Bug 1353181 followup - Fix non-DEBUG warnings-as-errors bustage.
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b6f0b34e87f2 https://hg.mozilla.org/mozilla-central/rev/19c4e80bee84
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•3 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•