1353259 - Cleanup some dtrace related things

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1353259 - Remove rules.mk sections depending on DTRACE_LIB_DEPENDENT.

Nothing sets DTRACE_LIB_DEPENDENT.

Review commit: https://reviewboard.mozilla.org/r/126240/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126240/

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1353259 - Remove build system parts that generate a dtrace ELF object.

The code doing that was already excluding OSX, so we obviously don't
need it on OSX. On FreeBSD, afaict, USDT (userspace dtrace) probes don't
require that extra ELF object. Solaris presumably does, but the 6 years
old bug 702179 says it's not been working for that long, and configure
doesn't support Solaris targets anyways.

Keeping this build system code working past the changes coming in bug
1262241 is not guaranteed and can't be tested, so I'd rather get rid of
effectively dead code rather than trying to maybe not break it while
moving it.

Review commit: https://reviewboard.mozilla.org/r/126242/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126242/

Comment 3

[Mike Hommey [:glandium]]

Jan, can you check if that works for FreeBSD? As mentioned in the commit message of the second patch, AFAICT, FreeBSD doesn't actually need the file generated by dtrace -G. Even if it does, I'd still rather remove this code anyways, it can be added after bug 1262241 (and should live entirely in js/src anyways)

Comment 4

[Jan Beich]

Doesn't build on FreeBSD which have been using bug 702179 fix for ~3 years.

../../js/src/jsarray.o: In function `js::NewDenseEmptyArray(JSContext*, JS::Handle<JSObject*>, js::NewObjectKind)':
js/src/jsarray.cpp:(.text._ZN2js18NewDenseEmptyArrayEP9JSContextN2JS6HandleIP8JSObjectEENS_13NewObjectKindE+0x3a4): undefined reference to `__dtraceenabled_javascript___object__create'
/usr/bin/ld: ../../js/src/jsarray.o: relocation R_X86_64_PC32 against `__dtraceenabled_javascript___object__create' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value

Comment 5

[Michael Shal [:mshal]]

Comment on attachment 8854304 [details]
Bug 1353259 - Remove rules.mk sections depending on DTRACE_LIB_DEPENDENT.

https://reviewboard.mozilla.org/r/126240/#review129046

Comment 6

[Michael Shal [:mshal]]

Comment on attachment 8854305 [details]
Bug 1353259 - Remove build system parts that generate a dtrace ELF object.

https://reviewboard.mozilla.org/r/126242/#review129048

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cdba772d904d
Remove rules.mk sections depending on DTRACE_LIB_DEPENDENT. r=mshal
https://hg.mozilla.org/integration/autoland/rev/db92496e83dd
Remove build system parts that generate a dtrace ELF object. r=mshal

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cdba772d904d
https://hg.mozilla.org/mozilla-central/rev/db92496e83dd