135336 - right click on personal toolbar and select New Folder does not work: javascript error

Status: RESOLVED DUPLICATE of bug 134620

(SeaMonkey :: Bookmarks & History, defect)

Description

[Vadim Berezniker]

linux trunk 2002040302
you get the following error:
Error: this.getBestItem is not a function
Source File: chrome://communicator/content/bookmarks/bookmarksOverlay.js
Line: 384

Comment 1

[Vadim Berezniker]

oops. fixing summary.

Comment 2

[Tuukka Tolvanen (sp3000)]

Seeing this on current linux cvs. Broken on 2002-03-28:
2002-03-28-09-trunk nightly works
2002-03-28-21-trunk nightly bugs

Comment 3

[Samir Gehani]

Nav triage team: nsbeta1-

Comment 4

[André Dahlqvist]

I see this too on 2002-04-07-13 on Linux. Creating folders in Manage Bookmarks
works however, so New Folder on the context menu on the PT must call some other
function.

Nominating for mozilla 1.0.

Comment 5

[André Dahlqvist]

Between 2002-03-28-09 and 2002-03-28-21 hewitt's outliner->tree rework checkin
landed, so this is probably a fallout from that.

CC-ing hewitt.

Comment 6

[André Dahlqvist]

Found it. Here is the checkin that removes get getBestItem function:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/xpfe/browser/resources/content&command=DIFF_FRAMESET&file=personalToolbar.js&rev1=1.9&rev2=1.10&root=/cvsroot

Comment 7

[André Dahlqvist]

This bug is still present in 2002-04-12-13.

Hewitt, can you take a look at this?

Comment 8

[Vadim Berezniker]

*** Bug 139871 has been marked as a duplicate of this bug. ***

Comment 9

[Leo H]

I have fix for this.  See bug 138523 and bug 134620

Comment 10

[André Dahlqvist]

Duping myself.

*** This bug has been marked as a duplicate of 134620 ***

Comment 11

[Jeremy M. Dolan]

*** Bug 136385 has been marked as a duplicate of this bug. ***